Drop the lazyeval dependency in favour of rlang#2485
Open
mcol wants to merge 1 commit intoplotly:masterfrom
Open
Drop the lazyeval dependency in favour of rlang#2485mcol wants to merge 1 commit intoplotly:masterfrom
mcol wants to merge 1 commit intoplotly:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal PR based on #2319, but the tests that were failing there are now passing. The main issue was that we have to manually pass the formula environment in
eval_attr(), otherwise the names referenced by the formula cannot be found.Note that at the moment
lazyevalhas problems building on R-devel due to changes in the underlying C implementation of environment and promises. Given that the package has been retired for a few years now, it seems like a good time to remove this dependency.