remove frameOrder warning #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cpsievert merged 5 commits into plotly:master from FrankBornais:fix-plotly-1919

Mar 8, 2021

FrankBornais commented Mar 7, 2021

*fix #1919

FrankBornais added 4 commits

March 7, 2021 13:18


          remove frameOrder warning

f7c3277


          use expect_warning

1f77d1a


          fix bunch of tests warnings

a12e05b


          update expected shinytest (jquery and crosstalk versions)

3c6e9e6

cpsievert reviewed

View reviewed changes

tests/testthat/test-ggplot-dynamicTicks.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

tests/testthat/test-ggplot-dynamicTicks.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

tests/testthat/test-cookbook-axes.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

tests/testthat/test-cookbook-axes.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

tests/testthat/test-ggplot-ticks.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

tests/testthat/test-plotly-linetype.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

tests/testthat/test-plotly-symbol.R Outdated Show resolved Hide resolved

cpsievert approved these changes

View reviewed changes

Collaborator

cpsievert left a comment

Thanks! LGTM once suggestions are applied (please apply them)


          Apply suggestions from code review

34134e4

Co-authored-by: Carson Sievert <cpsievert1@gmail.com>

cpsievert merged commit 9abcba9 into plotly:master

FrankBornais deleted the fix-plotly-1919 branch

March 13, 2021 01:53

cpsievert mentioned this pull request

fix traceNames with frames #1932

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet