Skip to content

Updates to Angular 13 and enables support for Ivy distribution - #230

Merged
andrefarzat merged 6 commits into
plotly:masterfrom
rk-7:master
Apr 6, 2023
Merged

Updates to Angular 13 and enables support for Ivy distribution#230
andrefarzat merged 6 commits into
plotly:masterfrom
rk-7:master

Conversation

@rk-7

@rk-7 rk-7 commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Updates the package to Angular 13 and enables support for Ivy distribution

  • Pumps up the version to 5.0.0
  • Migrates the project from tslit to eslint
  • Fixes version mismatches for Jasmin
  • Removes the dev dependency of protractor
  • Fixes vulnerabilities reported by npm

fixes #181

NB: I will add separate PR for Angular version 14 and 15 with major version updated to v6, and v7 respectively. Please let me know if this is okay. This is to support the projects on specific version of Angular to use specific version of this library.

Please provide your feedback. @andrefarzat @fischor @afarzat-ed @abierbaum @alyst

rk-7 added 6 commits March 28, 2023 23:19
This commit fixes vulnerabilities reported by npm.
Before:
45 vulnerabilities (2 low, 15 moderate, 20 high, 8 critical)

After:
17 vulnerabilities (1 low, 7 moderate, 7 high, 2 critical)
- updates the dependencies to use Angular 13
- compilation mode set to Ivy Partial
- updates the version to 5.0.0

BREAKING CHANGE: it is NOT backwards compatible with v12 due to Ivy.
- adds eslint schematics
- migrates the project to use eslint
- removes tslint
- removes codelyzer since it is no longer needed

This commit migrates the project from tslint to eslint
- removes protractor
- updates coveralls
- fixes vulnerabilities reported by npm

Note: 2 vulnerabilities cannot be fixed since the latest version of coveralls uses the package request which is deprecated.
@Abildtoft

Copy link
Copy Markdown

LGTM, I appreciate the strategy for version upgrades.

@andrefarzat
andrefarzat merged commit 4ee656d into plotly:master Apr 6, 2023
@andrefarzat

Copy link
Copy Markdown
Collaborator

Just released the v5.0.0 version: https://www.npmjs.com/package/angular-plotly.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Ivy Distribution

3 participants