BUGFIX EXTPLESK-8950 Fix case when getAll returns 1 database instead of 0#188
Open
whytea91 wants to merge 1 commit intoplesk:masterfrom
Open
BUGFIX EXTPLESK-8950 Fix case when getAll returns 1 database instead of 0#188whytea91 wants to merge 1 commit intoplesk:masterfrom
whytea91 wants to merge 1 commit intoplesk:masterfrom
Conversation
sibprogrammer
requested changes
Feb 3, 2026
whytea91
force-pushed
the
bugfix-correctly-fetch-current-databases-number
branch
from
619c2b3 to
73c3eeb
Compare
sibprogrammer
requested changes
Feb 4, 2026
src/Api/Operator/Database.php
Outdated
| $items = []; | ||
| foreach ((array) $response->xpath('//result') as $xmlResult) { | ||
| if ($xmlResult) { | ||
| if (isset($xmlResult->id) && (int) $xmlResult->id > 0) { |
Member
There was a problem hiding this comment.
$xmlResult check was removed w/o a reason. Please also make sure composer lint doesn't emit any errors.
whytea91
force-pushed
the
bugfix-correctly-fetch-current-databases-number
branch
from
73c3eeb to
c298f6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no databases on a domain, the API returns:
However, the getAll method returns one object with empty values (because if ($xmlResult) is always true, even when there are no DBs).