GzipFilter: Add Vary header for compressible responses even when not gzipped#13822
Open
tsawada wants to merge 2 commits intoplayframework:mainfrom
Open
GzipFilter: Add Vary header for compressible responses even when not gzipped#13822tsawada wants to merge 2 commits intoplayframework:mainfrom
tsawada wants to merge 2 commits intoplayframework:mainfrom
Conversation
Author
|
Never mind. GzipFilter does compress responses that already has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
Previously, the Vary: Accept-Encoding header was only added when the response was actually gzipped. Now it is also added when the response is compressible but not gzipped (e.g., when the client doesn't send Accept-Encoding: gzip).
I believe this behavior better conforms to the standard, because the Vary header must indicate that the response depends on the Accept-Encoding request header, preventing downstream caches from incorrectly serving a cached uncompressed response to subsequent clients that support compression.
The diff is larger than it should be, due to indentation changes. Please let me know if you have any suggestions to minimize it.
Part of #12981