Skip to content

revert back to metadata name #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OmkarDeshpande7 merged 1 commit into from
Jul 31, 2025
Merged

revert back to metadata name #780

OmkarDeshpande7 merged 1 commit into from
Jul 31, 2025

Conversation

@spai-p9
Copy link
Collaborator

@spai-p9 spai-p9 commented Jul 31, 2025 •
edited by bito-code-review bot
Loading

What this PR does / why we need it

Which issue(s) this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)

fixes #

Special notes for your reviewer

Testing done

please add testing details (logs, screenshots, etc.)

Summary by Bito

This PR reverts to using metadata-dependent display names for clusters in the migration feature. It updates UI components and cluster data mapping to ensure correct display properties. Type definitions and rendering logic were adjusted to provide more consistent and reliable cluster information display throughout the application.

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jul 31, 2025 •
edited
Loading

Code Review Agent Run #0b1ac7

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 41de38f..41de38f
    • ui/src/features/migration/SourceDestinationClusterSelection.tsx
    • ui/src/features/migration/useClusterData.ts
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

AI Code Review powered by Bito Logo

windsurf-bot[bot]
windsurf-bot bot reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jul 31, 2025

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Bug Fix - Bug Fix: Revert to Metadata-Based Display

- SourceDestinationClusterSelection.tsx - Replaced cluster name with cluster displayName in UI templates and updated type annotations to include displayName.

- useClusterData.ts - Modified cluster mapping logic to derive name and displayName from metadata and spec respectively, ensuring consistency.

@OmkarDeshpande7 OmkarDeshpande7 enabled auto-merge (squash) July 31, 2025 12:10
@OmkarDeshpande7 OmkarDeshpande7 force-pushed the private/main/fix-esxi-in-ui branch from 41de38f to 555112e Compare July 31, 2025 12:10
@OmkarDeshpande7 OmkarDeshpande7 merged commit a8ede90 into main Jul 31, 2025
12 checks passed
@OmkarDeshpande7 OmkarDeshpande7 deleted the private/main/fix-esxi-in-ui branch July 31, 2025 12:19
@sharma-tapas sharma-tapas mentioned this pull request Jul 31, 2025
Closed
8 tasks
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jul 31, 2025 •
edited
Loading

Bito Review Skipped - Source Branch Not Found

Bito didn’t review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windsurf-bot windsurf-bot[bot] windsurf-bot[bot] left review comments

@sharma-tapas sharma-tapas sharma-tapas approved these changes

@OmkarDeshpande7 OmkarDeshpande7 OmkarDeshpande7 approved these changes

@sarika-pf9 sarika-pf9 Awaiting requested review from sarika-pf9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spai-p9 @sharma-tapas @OmkarDeshpande7