Skip to content

Conversation

@spai-p9
Copy link
Collaborator

@spai-p9 spai-p9 commented Dec 16, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)

fixes #1268

Special notes for your reviewer

Testing done

please add testing details (logs, screenshots, etc.)

Summary by Bito

  • This pull request introduces the installation of the vjbctl binary as a system-wide command by modifying the existing install script.
  • It modifies the existing install script to include the necessary commands for setting up vjbctl.
  • The changes ensure proper permissions for the htpasswd file.
  • It ensures that the necessary permissions are set for the vjbctl binary, enhancing the installation process and permissions management.
  • Overall, the changes facilitate the use of vjbctl as a system-wide utility.
  • Overall, the changes touch on the installation process and permissions management, introducing the vjbctl command as a system-wide utility.

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

spai-p9 and others added 2 commits December 16, 2025 16:15
Co-authored-by: windsurf-bot[bot] <189301087+windsurf-bot[bot]@users.noreply.github.com>
Signed-off-by: K Suhas Pai <suhas@platform9.com>
Co-authored-by: windsurf-bot[bot] <189301087+windsurf-bot[bot]@users.noreply.github.com>
Signed-off-by: K Suhas Pai <suhas@platform9.com>
sudo cat > /usr/local/bin/vjbctl << 'EOF'
#!/bin/bash
source /etc/pf9/pf9-htpasswd.sh
_pf9_ht_main "$@"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vjbctl not available when logged in as root.

3 participants