Implement Session Timeout (18 hours inactivity) for UI #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meghansh-pf9
force-pushed
the
private/main/megh/logout-nginx
branch
from
58196b4 to
e4ab81e
Compare
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (2)
- ui/default.conf (33-33) You're using `ngx.ERR` log level for informational messages like "Session Stable Renewing the session". Consider using `ngx.INFO` or `ngx.DEBUG` for these non-error messages to keep your error logs clean.
- ui/default.conf (64-64) Similarly, use `ngx.INFO` or `ngx.DEBUG` instead of `ngx.ERR` for the login success message.
💡 To request another review, post a new comment with "/windsurf-review".
ui/default.conf
Outdated
Comment on lines
34
to
35
| ngx.header["Set-Cookie"] = "auth_session=" .. now | ||
| .. "; Path=/; HttpOnly; Secure; SameSite=Lax" |
Contributor
There was a problem hiding this comment.
Consider using SameSite=Strict instead of SameSite=Lax for the auth_session cookie. The Strict setting provides better protection against CSRF attacks by preventing the cookie from being sent in cross-site requests, which is appropriate for authentication cookies.
meghansh-pf9
requested review from
OmkarDeshpande7,
sarika-pf9 and
sharma-tapas
meghansh-pf9
force-pushed
the
private/main/megh/logout-nginx
branch
from
e4ab81e to
bccbc46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR introduces an explicit 18-hour inactivity-based session expiration mechanism for the UI that uses Basic Authentication. Previously, Basic Auth sessions could persist indefinitely or be governed by less explicit browser/OS behavior. To enhance security and resource management, a Lua script has been integrated into the Nginx configuration. This script explicitly tracks user activity and invalidates the session credential after 18 hours of continuous inactivity, forcing the user to re-authenticate and thereby ensuring that access is revoked for dormant sessions.
fixes #1263
Testing done
Screen.Recording.2025-12-12.at.2.25.25.PM.mov
please add testing details (logs, screenshots, etc.)
Summary by Bito