Skip to content

Commit b4660fe

Browse files
committed
TestServerGeneral: Add test for _format_servers_list_networks()
The items in a dict are in random order. So if a server is in two networks, there may be two results after formatted. Change-Id: I2e15d202639e3fff427935f46650a405b0e51bcc Implements: blueprint osc-unit-test-framework-improvement
1 parent b220f4b commit b4660fe

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

openstackclient/tests/compute/v2/test_server.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,3 +1136,27 @@ def test_format_servers_list_power_state(self):
11361136
server._format_servers_list_power_state(0x07))
11371137
self.assertEqual("N/A",
11381138
server._format_servers_list_power_state(0x08))
1139+
1140+
def test_format_servers_list_networks(self):
1141+
# Setup network info to test.
1142+
networks = {
1143+
u'public': [u'10.20.30.40', u'2001:db8::f'],
1144+
u'private': [u'2001:db8::f', u'10.20.30.40'],
1145+
}
1146+
1147+
# Prepare expected data.
1148+
# Since networks is a dict, whose items are in random order, there
1149+
# could be two results after formatted.
1150+
data_1 = (u'private=2001:db8::f, 10.20.30.40; '
1151+
u'public=10.20.30.40, 2001:db8::f')
1152+
data_2 = (u'public=10.20.30.40, 2001:db8::f; '
1153+
u'private=2001:db8::f, 10.20.30.40')
1154+
1155+
# Call _format_servers_list_networks().
1156+
networks_format = server._format_servers_list_networks(networks)
1157+
1158+
msg = ('Network string is not formatted correctly.\n'
1159+
'reference = %s or %s\n'
1160+
'actual = %s\n' %
1161+
(data_1, data_2, networks_format))
1162+
self.assertIn(networks_format, (data_1, data_2), msg)

0 commit comments

Comments
 (0)