Remove go 1.16 and 1.17. Add Go 1.22 and 1.23 into dynamic tracer test matrix #2120
Conversation
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
| pl_cc_bpf_test( | ||
| name = "go_tls_trace_bpf_test", | ||
| timeout = "moderate", | ||
| timeout = "long", |
There was a problem hiding this comment.
Given that go1.24 was recently released and the golang policy is to old support upto two versions too old, I think. you can drop 1.18. I'd probably also suggest dropping 1.19 too.
IMO increasing the test matrix too much doesn't seem worth it.
There was a problem hiding this comment.
Yea, I agree that we should deprecate those soon.
Omid had concerns that there might be older Go versions in use by end users despite Go's policy. I know of a few end users in this situation, so I might consider how to keep that test coverage without having our own dependencies tied to it.
If I decide to abandon keeping that coverage, at least its much easier to drop old support now with the dynamic logging stuff figured out. So a subsequent removal will be much easier.
|
As for the @pixie-io/stirling review, Omid and I discussed this change and was aligned with removing these Go versions (#2116 (review)). So I'm going to move forward with this change. |
ddelnano
deleted the
ddelnano/remove-go-1-16-1-17-and-more-version-coverage
branch
…t matrix (pixie-io#2120) Summary: Remove go 1.16 and 1.17. Add Go 1.22 and 1.23 into dynamic tracer test matrix Once Go 1.16 and 1.17 are removed from the repo, we can pursue go dependency upgrades like pixie-io#2115. I also added Go 1.22 and 1.23 (the latest versions) to dynamic tracer tests that ideally should cover multiple go versions. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Existing tests --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: fb868c6
2 participants
Summary: Remove go 1.16 and 1.17. Add Go 1.22 and 1.23 into dynamic tracer test matrix
Once Go 1.16 and 1.17 are removed from the repo, we can pursue go dependency upgrades like #2115. I also added Go 1.22 and 1.23 (the latest versions) to dynamic tracer tests that ideally should cover multiple go versions.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Existing tests