Add go 1.22 and 1.23 to socket tracer tests. Bump minor go versions #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
ddelnano/add-go-1.22-1.23-bump-minor-go-versions
branch
2 times, most recently
from
606704a to
f1e0a03
Compare
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…st timeout Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…from tls trace test Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/add-go-1.22-1.23-bump-minor-go-versions
branch
from
a4c9673 to
b334f6d
Compare
vihangm
approved these changes
Feb 11, 2025
oazizi000
approved these changes
Feb 11, 2025
Contributor
oazizi000
left a comment
oazizi000
left a comment
There was a problem hiding this comment.
In person discussion notes:
Let's think about removing 1.16 and 1.17 everywhere in the code. They are EOL'ed, and have security concerns.
ddelnano
deleted the
ddelnano/add-go-1.22-1.23-bump-minor-go-versions
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Aug 6, 2025
…ixie-io#2116) Summary: Add go 1.22 and 1.23 to socket tracer tests. Bump minor go versions This PR adds Go 1.22 and 1.23 to the socket tracer test suite in anticipation of removing Go 1.16 and 1.17 from our repo once pixie-io#2108 is merged. The plan is to follow this up with a change that removes Go 1.16 and 1.17 in addition to upgrading a portion of our Go dependencies. The bulk of our dependencies still support Go 1.18, so this will allow us to upgrade to the latest versions. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Test suite passes --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 09ade3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add go 1.22 and 1.23 to socket tracer tests. Bump minor go versions
This PR adds Go 1.22 and 1.23 to the socket tracer test suite in anticipation of removing Go 1.16 and 1.17 from our repo once #2108 is merged. The plan is to follow this up with a change that removes Go 1.16 and 1.17 in addition to upgrading a portion of our Go dependencies. The bulk of our dependencies still support Go 1.18, so this will allow us to upgrade to the latest versions.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Test suite passes