Upgrade rules_go to v0.47.1 for go 1.22 support #2113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
vihangm
approved these changes
Feb 11, 2025
ddelnano
deleted the
ddelnano/upgrade-rules_go_to-go-1-22-compatible-version
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Aug 6, 2025
Summary: Upgrade rules_go to v0.47.1 for go 1.22 support The work to remove our dependence on go 1.16 will be complete soon (once pixie-io#2108 is merged). With that done, we can upgrade our go dependencies and go version. This rules_go change is needed to support go 1.22 as there was an assembler fix in [v0.46.0](https://github.com/bazel-contrib/rules_go/releases/tag/v0.46.0) (bazel-contrib/rules_go#3756 specifically). This was the most recent rules_go version I could upgrade to without dealing with breaking changes. I'll revisit upgrading this to a newer version soon, but my primary goal was to be able to upgrade go and our go deps. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Existing tests and verified my branch to add go 1.22 as a supported version builds properly Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: b122242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade rules_go to v0.47.1 for go 1.22 support
The work to remove our dependence on go 1.16 will be complete soon (once #2108 is merged). With that done, we can upgrade our go dependencies and go version. This rules_go change is needed to support go 1.22 as there was an assembler fix in v0.46.0 (bazel-contrib/rules_go#3756 specifically).
This was the most recent rules_go version I could upgrade to without dealing with breaking changes. I'll revisit upgrading this to a newer version soon, but my primary goal was to be able to upgrade go and our go deps.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Existing tests and verified my branch to add go 1.22 as a supported version builds properly