Skip to content

Conversation

@ddelnano
Copy link
Member

@ddelnano ddelnano commented Sep 4, 2024

Summary: Use correct byte ordering function for kernel struct member (skc_num)

This change doesn't result in a functional difference since ntohs and htons are inverses of each other on little endian machines (and noops for big endian machines). This field's byte order caused me confusion in #1989, so I wanted to make this struct access consistent.

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Testing during #1989 (details here)

@ddelnano ddelnano requested a review from a team as a code owner September 4, 2024 05:33
@ddelnano ddelnano requested a review from oazizi000 September 4, 2024 05:34
@ddelnano ddelnano requested a review from a team as a code owner September 4, 2024 14:14
ddelnano added a commit that referenced this pull request Sep 4, 2024
Summary: Update GitHub matrix to use correct 6.1.x kernel

Builds after #1995 would fail since GitHub would attempt to run the
6.1.8 kernel build, which bazel no longer understands. This also updates
the qemu test runner kernel that was incorrectly updated in #1999. I
thought I had exercised that default value with my testing, but it
didn't trigger that default value.

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: GitHub build on #2002 which pulls in the matrix change is no
longer failing
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
@ddelnano ddelnano force-pushed the ddelnano/fix-byte-ordering branch from 348d850 to 64f8171 Compare September 4, 2024 16:06
@ddelnano ddelnano merged commit 6fc0f18 into pixie-io:main Sep 16, 2024
@ddelnano ddelnano deleted the ddelnano/fix-byte-ordering branch September 16, 2024 23:25
ddelnano added a commit to ddelnano/pixie that referenced this pull request Sep 23, 2024
Summary: Update GitHub matrix to use correct 6.1.x kernel

Builds after pixie-io#1995 would fail since GitHub would attempt to run the
6.1.8 kernel build, which bazel no longer understands. This also updates
the qemu test runner kernel that was incorrectly updated in pixie-io#1999. I
thought I had exercised that default value with my testing, but it
didn't trigger that default value.

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: GitHub build on pixie-io#2002 which pulls in the matrix change is no
longer failing

GitOrigin-RevId: 9ae53a8
ddelnano added a commit to ddelnano/pixie that referenced this pull request Sep 23, 2024
…pixie-io#2002)

Summary: Use correct byte ordering function for kernel struct member
(skc_num)

This change doesn't result in a functional difference since `ntohs` and
`htons` are inverses of each other on little endian machines (and noops
for big endian machines). This field's byte order caused me confusion in
pixie-io#1989, so I wanted to make this struct access consistent.

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Testing during pixie-io#1989 (details
[here](pixie-io#1989 (comment)))

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
GitOrigin-RevId: 6fc0f18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants