Skip to content

Move pom operator into codemodder-java repo#140

Closed
ryandens wants to merge 156 commits into
mainfrom
ryandens/inline-pom-operator
Closed

Move pom operator into codemodder-java repo#140
ryandens wants to merge 156 commits into
mainfrom
ryandens/inline-pom-operator

Conversation

@ryandens

@ryandens ryandens commented Aug 16, 2023

Copy link
Copy Markdown
Member

🚧

@ryandens ryandens force-pushed the ryandens/inline-pom-operator branch from d6ba5e6 to ddf1bd2 Compare August 24, 2023 22:48
@CLAassistant

CLAassistant commented Aug 24, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldrinleal What does this test do that others don't? Why can't the contents of the java-sample test be inlined into this test suite?

@aldrinleal aldrinleal Aug 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just to ensure it was able to be used from Java and consumed from a whole project without any Kotlin in a Vanilla JDK8 environment.

You can safely ignore that in your merging process (but perhaps wait bc I'd like to finish one more thing in the source pom-operator first)

@nahsra

nahsra commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

Closing this PR until we're a bit closer to mergeable state.

@nahsra nahsra closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants