Skip to content

MAINT: Move NestedPipeFunc to own module#688

Draft
basnijholt wants to merge 1 commit intomainfrom
move-nested
Draft

MAINT: Move NestedPipeFunc to own module#688
basnijholt wants to merge 1 commit intomainfrom
move-nested

Conversation

@basnijholt
Copy link
Collaborator

@basnijholt basnijholt commented Mar 19, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

✅ PR Title Formatted Correctly

The title of this PR has been updated to match the correct format. Thank you!

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 19, 2025
View reviewed changes
docs/source/conf.py


def setup(app):
def setup(app) -> None:

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning documentation

This assignment to 'setup' is unnecessary as it is
redefined
Loading
before this value is used.

Copilot Autofix

AI 11 months ago

To fix the problem, we need to remove the redundant assignment to setup on line 150. This will eliminate the unnecessary code and make the script cleaner and easier to maintain. We should ensure that the removal does not affect any other part of the code.

Suggested changeset 1
docs/source/conf.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/docs/source/conf.py b/docs/source/conf.py
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -149,4 +149,4 @@
 
-def setup(app) -> None:
-    app.add_directive("try-notebook", TryNotebookWithUV)
+
+
 
EOF
@@ -149,4 +149,4 @@

def setup(app) -> None:
app.add_directive("try-notebook", TryNotebookWithUV)



Copilot is powered by AI and may make mistakes. Always verify output.
pipefunc/_nested_pipefunc.py
if TYPE_CHECKING:
from collections.abc import Callable, Sequence

from pipefunc import Pipeline

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Pipeline' is not used.

Copilot Autofix

AI 11 months ago

To fix the problem, we need to remove the unused import statement. This will clean up the code and eliminate the unnecessary dependency. Specifically, we will delete the line from pipefunc import Pipeline from the file pipefunc/_nested_pipefunc.py.

Suggested changeset 1
pipefunc/_nested_pipefunc.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/pipefunc/_nested_pipefunc.py b/pipefunc/_nested_pipefunc.py
--- a/pipefunc/_nested_pipefunc.py
+++ b/pipefunc/_nested_pipefunc.py
@@ -15,3 +15,3 @@
 
-    from pipefunc import Pipeline
+
     from pipefunc._pipeline._types import OUTPUT_TYPE
EOF
@@ -15,3 +15,3 @@

from pipefunc import Pipeline

from pipefunc._pipeline._types import OUTPUT_TYPE
Copilot is powered by AI and may make mistakes. Always verify output.
@codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pipefunc/__init__.py 100.00% <100.00%> (ø)
pipefunc/_nested_pipefunc.py 100.00% <100.00%> (ø)
pipefunc/_pipefunc.py 100.00% <100.00%> (ø)
pipefunc/_pipeline/_base.py 100.00% <100.00%> (ø)
pipefunc/_pipeline/_simplify.py 100.00% <100.00%> (ø)
pipefunc/_plotting.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2025

CodSpeed Performance Report

Merging #688 will not alter performance

Comparing move-nested (2c433a5) with main (415cb73)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@basnijholt