Skip to content

feat(header): enable Chinese Lake docs entry - #735

Open
qiancai wants to merge 1 commit into
pingcap:masterfrom
qiancai:lake-support-zh
Open

feat(header): enable Chinese Lake docs entry#735
qiancai wants to merge 1 commit into
pingcap:masterfrom
qiancai:lake-support-zh

Conversation

@qiancai

@qiancai qiancai commented Sep 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

What

  • enable the TiDB Cloud Lake entry on the Chinese documentation site and link it to /zh/tidbcloudlake/
  • keep the TiDB Cloud Lake entry disabled on the Japanese documentation site
  • make the AI-translation banner on Chinese Lake pages link to the corresponding English Lake page

Why

This change supports the Chinese translation of the TiDB Cloud Lake documentation introduced by pingcap/docs#23843. It should take effect after that documentation PR is merged.

Tests

  • pnpm exec prettier --check src/components/Layout/Header/HeaderNavConfigData.tsx src/components/Layout/Header/index.tsx
  • pnpm exec jest gatsby/__tests__/toc-namespace.test.ts gatsby/url-resolver/__tests__/url-resolver.test.ts gatsby/link-resolver/__tests__/link-resolver.test.ts --runInBand --coverage=false (203 tests passed)

Summary by CodeRabbit

  • Bug Fixes
    • TiDB Cloud Lake navigation is now available for Chinese-language pages while remaining disabled for Japanese-language pages.
    • Automatic translation links for TiDB Cloud Lake pages now use the correct destination path, improving navigation between localized versions.

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

@qiancai is attempting to deploy a commit to the pingcap Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 457c6bb7-8e51-455f-b4e0-4aa1799ef2c4

📥 Commits

Reviewing files that changed from the base of the PR and between 688010b and bdbaeb4.

📒 Files selected for processing (2)
  • src/components/Layout/Header/HeaderNavConfigData.tsx
  • src/components/Layout/Header/index.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The header enables TiDB Cloud Lake navigation for Chinese and generates a dedicated automatic translation URL for TiDB Cloud Lake pages.

Changes

TiDB Cloud Lake header behavior

Layer / File(s) Summary
Navigation availability and banner URL
src/components/Layout/Header/HeaderNavConfigData.tsx, src/components/Layout/Header/index.tsx		 The navigation item is disabled only for Japanese. HeaderBanner maps the TOCNamespace.TiDBCloudLake namespace to /tidbcloudlake/${name}.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: shhdgit

Merge Risk: ⚪ Minimal · up to bdbae

The Chinese navigation and Lake translation link changes match the intended routing behavior and are ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling the Chinese TiDB Cloud Lake documentation entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the header bright
TiDB Cloud Lake paths now point right
Chinese links can hop along
Japanese waits where it belongs
The banner finds its trail tonight

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shhdgit shhdgit shhdgit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qiancai @shhdgit