Adding me and my Board - #564
Merged
Merged
Conversation
Contributor
Author
|
Will pull again with correct licence listed! |
This was referenced Oct 14, 2020
Merged
tannewt
requested changes
Oct 14, 2020
tannewt
left a comment
tannewt
left a comment
Collaborator
There was a problem hiding this comment.
Please post the native hardware design files along with a LICENSE file for them in the repos. We don't consider schematic images open because they cannot be modified to produce different hardware.
Contributor
Author
|
I think I got it now. The jpeg was just a placeholder, I hadn't pushed the KiCad files! Thanks for all your help. |
Contributor
Author
|
I think I've managed to do it right this time. |
tannewt
requested changes
Oct 20, 2020
tannewt
left a comment
tannewt
left a comment
Collaborator
There was a problem hiding this comment.
Please switch to PIDs that don't start with 0 or 1. Repo looks good! I'd suggest renaming the license file to LICENSE because it's a standard filename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to get the new Beta version of Circuit Python to run on modules on my board, I needed PIDs hope I've done this right I'm on my first day actually using GIT!