Added Robotics-Masters and the MM1 Hat - #421
Merged
Merged
Conversation
Arachnid
requested changes
May 6, 2019
Arachnid
left a comment
Arachnid
left a comment
Contributor
There was a problem hiding this comment.
Please make sure all of your linked repositories exist and have appropriate LICENSE files.
Also, can you clarify why the hat itself needs a VID, in addition to all the VIDs for specific applications?
Contributor
Author
|
Hi Nick, I fixed the changed repo URL, renamed the LICENCE to LICENSE in the schematics repo and have Cian add a LICENSE file to the bootloader repo. Regarding the board VID, it will be used in production with an automated testing device, but we will flash the bootloader before shipping, so it will not be seen in the wild. |
Contributor
|
If the PID for the board won't be used in the wild, could you use one of our test PIDs, instead of allocating a public one for it? |
Arachnid
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We support a set of different bootloaders and firmware choices for our board to make it as accessible as possible for the different communities, for this reason we request differnet VID for each of the boards usecases.
We are working on adding Ardupilot and Dronecode support at the moment and would like to request continuous VIDs 0x4D46 and 0x4D47 for the programming USB device in those i the near future.