Request PIDs for my keyboard projects - #152
Merged
Merged
Conversation
Contributor
|
Thanks for your PR! Can you please add LICENSE files to your repositories so people know what license they're under? If this is for hardware you designed yourself, you need to include design files sufficient to producing the hardware in your repositories as well. |
Contributor
Author
|
Thanks for the prompt response. Sorry that I misunderstood the How shall I do since I have separated repos for hardware and firmware? |
Contributor
|
My mistake, I only checked out the source URLs. LGTM. |
Contributor
Author
|
No problem. Thank you very much for the merging. Anyway please let me know if there is anything I should do to improve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you very much for this service!