Striped table rows cleancss fix#663
Open
Yohn wants to merge 2 commits into
Open
Conversation
Its a little dirty, but it works. CleanCSS was causing the issue, and we can tell it to not modify that code block. I tried it a few different ways before I settings with this.
Member
|
@Yohn, great find, you are right, it's the minifier. I did more tests and actually we could do this: tbody {
// Striped rows skip hidden elements (`odd of :not([hidden])`), `:is()` prevents minifier issues.
tr:is(:nth-child(odd of :not([hidden]))) {
th,
td {
background-color: var(#{$css-var-prefix}table-row-stripped-background-color);
}
}
}What do you think? |
Author
|
Nice find! Idk why I didn't think to try |
use `:is()`
Amaury
added a commit
to Digicreon/muCSS
that referenced
this pull request
Mar 22, 2026
…#663). Progressive enhancement with fallback for older browsers.
|
We applied this fix in µCSS, using We didn't need the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its a little dirty, but it works. CleanCSS was causing the issue, and we can tell it to not modify that code block. I tried it a few different ways before I settings with this.