Repository navigation
Add regression test for #12743 - #6789
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
//cc @SanderMuller |
staabm
approved these changes
Oct 23, 2026
SanderMuller
left a comment
SanderMuller
left a comment
Contributor
There was a problem hiding this comment.
I checked 7974bc7.
- The test passes on this head. With it on 87bbf77, the parent of #6695, it fails with
Expected: int, Actual: nullandExpected: string, Actual: null. So #6695 is the fix, which matches the bot's comparison on the issue. - The reporter's snippet on this head only reports the two
Root<1>andRoot<2>assertions. I agree withBase<1>andBase<2>:becomeInt()returnsstatic<self::INT>, andstaticisBasehere. - The test also passes with the turbo extension active (macOS arm64, PHP 8.5).
lint >= 8.0is needed for thematchinexecute().- There is no source change, so there is no performance effect.
- The two red jobs,
result-cache-parse-errorand the Tempest integration job, also fail on other current 2.3.x PRs.
One thing: the description has no Closes phpstan/phpstan#12743, so close-issues-on-merge.yml will not close the issue after the merge.
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for phpstan/phpstan#12743.
On the current
2.3.xthe conditional return type ofexecute()is resolved again for the snippet from the issue (null,int,stringforBase<0>,Base<1>,Base<2>). The two remaining errors the playground reports on the original snippet come from its own assertions:static<self::INT>called on aBase<0>isBase<1>, notRoot<1>, so the test assertsBase<1>andBase<2>.🤖 Generated with Claude Code