Simplify MutatingScope->compareVariableTypeHolders()

staabm · ondrejmirtes · commit e453085cb1e3 · 2025-12-20T09:20:13.000+01:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -5637,8 +5637,6 @@ private function compareVariableTypeHolders(array $variableTypeHolders, array $o
 			if (!$variableTypeHolder->getType()->equals($otherVariableTypeHolders[$variableExprString]->getType())) {
 				return false;
 			}
-
-			unset($otherVariableTypeHolders[$variableExprString]);
 		}
 
 		return true;

Original file line number	Diff line number	Diff line change
`@@ -5637,8 +5637,6 @@ private function compareVariableTypeHolders(array $variableTypeHolders, array $o`
`5637`	`5637`	`if (!$variableTypeHolder->getType()->equals($otherVariableTypeHolders[$variableExprString]->getType())) {`
`5638`	`5638`	`return false;`
`5639`	`5639`	`}`
`5640`		`-`
`5641`		`- unset($otherVariableTypeHolders[$variableExprString]);`
`5642`	`5640`	`}`
`5643`	`5641`
`5644`	`5642`	`return true;`