Repository navigation
Jean85\PrettyVersions not found #525
Description
Both composer global install and phar fail with:
phpstan.phar
PHP Fatal error: Uncaught Error: Class 'PHPStanVendor\Jean85\PrettyVersions' not found in phar:///usr/local/bin/phpstan.phar/bin/phpstan:23
Stack trace:
#0 /usr/local/bin/phpstan.phar(4): require()
#1 {main}
thrown in phar:///usr/local/bin/phpstan.phar/bin/phpstan on line 23
In addition, https://github.com/phpstan/phpstan/releases/tag/0.8.5 is missing phar.
Activity
ondrejmirtes commentedon Sep 29, 2017
umpirsky commentedon Sep 29, 2017
Composer
composer global require phpstan/phpstanPhar
ondrejmirtes commentedon Sep 29, 2017
Could not reproduce your problem:
Composer
Phar
ondrejmirtes commentedon Sep 29, 2017
And the missing phar issue for 0.8.5 is a duplicate of #496.
umpirsky commentedon Sep 29, 2017
Not sure why this happens, file is there:
Looks like autoload issue.
ondrejmirtes commentedon Sep 29, 2017
Feel free to debug it, I have no idea what can it be caused by 😊 cc @Jean85
umpirsky commentedon Sep 29, 2017
My packages:
Jean85 commentedon Sep 29, 2017
The only strange stuff that I can see is
Class 'PHPStanVendor\Jean85\PrettyVersions'.. Who's prependingPHPStanVendorin the namespace? PHPStan's PHAR has some autoloader additions?umpirsky commentedon Sep 29, 2017
@Jean85 That happens only for phar, with composer global it's just
Jean85\PrettyVersions. I guess phar is prependingPHPStanVendornamespace to prevent collision with root.Jean85 commentedon Sep 29, 2017
Ok, understood. Since yours seems to be a config problem, can you post your environment spec?
umpirsky commentedon Sep 29, 2017
@Jean85 What do you need?
Jean85 commentedon Oct 2, 2017
Ok, you're using Linux like me. Are you using any other tech? Docker? VM? I cannot reproduce this too. Maybe you have some basic PHP extension disabled?
umpirsky commentedon Oct 2, 2017
@Jean85 I use both vagrant and docker, but this (phpstan) is run on bare metal.
Jean85 commentedon Oct 2, 2017
Composer version in use?
BTW I'm not able to reproduce it with an isolated Docker env, using this command:
11 remaining items
ondrejmirtes commentedon Nov 6, 2017
@Jean85 Do you have a suggestion how to prevent this error in case both are installed?
Jean85 commentedon Nov 6, 2017
Maybe generating a random namespace prefix in the PHAR? It's a hack, but since it's hard to pin down why this clash occurs...
ondrejmirtes commentedon Nov 6, 2017
I must admit that I do not understand the nature of the problem. The problem is
Fatal error: Uncaught Error: Class 'PHPStanVendor\Jean85\PrettyVersions' not found. And the class exists in two versions when this occurs:So I don't get why does it result in this error.
dkarlovi commentedon Nov 7, 2017
Question is, why is PHAR allowing its autoloader to get overriden? Shouldn't it all be baked in by default?
ondrejmirtes commentedon Nov 7, 2017
PHPStan needs to autoload classes from the analyzed project.
dkarlovi commentedon Nov 7, 2017
So, is this error coming from the autoloader loading PHPStan itself or PHPStan's autoloader? It seems like the former, still feels like that autoloader should be untouched by the project's autoloader.
Basically, PHPStan should use own autoloader for itself always, they shouldn't come into contact.
Jean85 commentedon Nov 7, 2017
Umh.... maybe the autoloaders are not chained correctly and the local one overrides the one inside the PHAR?
dkarlovi commentedon Nov 7, 2017
That's exactly what I'm thinking. So, autoloader loading PHPStan (ALPS) should be classmap-based, and the class map is built when the PHAR is built. After that, PHPStan's autoloader (PSA) which is probably just loading the project's
autoload.phpwould kick in.This way, the autoload process would go
If PHAR is trying to load itself, it would always succeed in 1) and it should never reach beyond that. Everything else is loaded from 2) forward (ALPS always misses). It probably works like this already, but something is off by one somewhere. I'm guessing so because PSA is error-managed by PHPStan already, ALPS isn't.
dinamic commentedon May 17, 2018
ping
ondrejmirtes commentedon May 17, 2018
@dinamic Why are you pinging? This is not a solved issue, if you have a solution, I'm open for it.
The problem is that globally and locally installed PHPStan instances clash. So if you see this error it means that you're either:
composer require -g.composer require -g) while there's one installed localy in a project.dinamic commentedon May 17, 2018
Steps to reproduce in my instance:
composer require phpstan/phpstan-phpunit --devinto the projectRequiring
phpstan/phpstan-phpunitwould require alsophpstan/phpstan, which seems to be causing the problem here.Maybe
phpstan/phpstan-phpunitcan suggestphpstan/phpstan, but not require it?dinamic commentedon May 17, 2018
@ondrejmirtes, just suggested a solution. Maybe we were typing at the same time.
ondrejmirtes commentedon May 17, 2018
@dinamic You have a completely different problem and this error is just a side effect. When using PHPStan with its extensions, they have to see each other. So when using the docker image, you have to install PHPStan extensions alongside PHPStan. See "Install PHPStan extensions" at https://github.com/phpstan/docker-image/blob/master/README.md
dinamic commentedon May 17, 2018
I'm using jakzal's phpqa docker image, so I will request the extension to be installed there.
Thanks for the solution, @ondrejmirtes! Much appreciated!