Repository navigation
Regression: regex matches after checking non-empty array #14270
Description
Bug report
What do you think about this? /cc @staabm
public function getDuration(string $path): void {
preg_match('~^([a-z]+)\\:\\/\\/(.+)~', $path, $matches);
$scheme = null;
if ($matches !== []) {
[, $scheme, $path] = $matches;
}
}I think if the array is non-empty then the keys will exist, right? But PHPStan reports:
Offset 1 might not exist on non-empty-list{0?: string, 1?: non-empty-string, 2?: non-empty-string}.
Offset 2 might not exist on non-empty-list{0?: string, 1?: non-empty-string, 2?: non-empty-string}.
Code snippet that reproduces the problem
https://phpstan.org/r/9344ca07-6178-44d2-844b-b2b3903d2a2b
Expected output
No errors
Did PHPStan help you today? Did it make you happy in any way?
No response
Activity
ondrejmirtes commentedon Mar 12, 2026
Regression in 5b79cca6d4186fb25d807adb9ca80b84664f7ec2
VincentLanglet commentedon Mar 12, 2026
Hi,
This is not really a regression.
This is a duplicate of #11602 in which we thought the issue was solved but it's just it that every
might not exist on non-empty-listerror (even if it was a false positive or a real error) was not reported.This was the section
Currently a workaround is https://phpstan.org/r/3d5430ba-5821-4df1-b007-ad4094919527
Fix regression in offset access check on non-empty narrowed arrays
Fix preg_match type inference: return union of empty and matched types
Fix phpstan/phpstan#14270: Regression: regex matches after checking n…
phpstan-bot commentedon Mar 12, 2026
Closed via merging phpstan/phpstan-src#5209
Updated PHPStan to commit 024a65c3146a554e0d872f19fe07acb5e6ab2a29
Updated PHPStan to commit 8d36b11ec59027617a44b0171cadc9b20f727b91
Fix phpstan/phpstan#14270: Regression: regex matches after checking n…
github-actions commentedon Apr 13, 2026
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.