Repository navigation
if ($value > 0) proves that $value is not false #1272
Description
PHPStan 0.10.x
Summary of a problem or a feature request
<?php
function acceptsInt(int $value) {}
/** @var int|false */
$value = false;
if ($value > 0) {
acceptsInt($value);
}Parameter #1 $value of function acceptsInt expects int, int|false given.
if ($value > 0) { proves that $value is not false. PHPStan thinks that it still might be false.
Currently, I need to use if ($value !== false && $value > 0) to silence PHPStan.
Code snippet that reproduces the problem
https://phpstan.org/r/0dda040f8e4c229b7fdc68bffae405f8
https://3v4l.org/YuWIQ
Expected output
No error.
Activity
JanTvrdik commentedon Jul 23, 2018
And to make to code readable for humans.
iluuu1994 commentedon Jul 23, 2018
Absolutely. That's why "PHPStan-strict-rules" has rules to avoid comparisons of non-number types.
But I still think PHPStan should avoid false positives.
ondrejmirtes commentedon Jan 8, 2021
Already implemented by phpstan/phpstan-src#390
github-actions commentedon May 2, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.