typehint for range() does not suggest string[] #1201

Activity

1. sanmai

   changed the title [-]typehint for range() does not suggest string[/-] [+]typehint for range() does not suggest string[][/+] on Jul 11, 2018
2. ondrejmirtes commented on Jul 11, 2018

   

   ondrejmirtes

   on Jul 11, 2018 via email

   Member

   More actions

   This is weird, can you please follow the guidelines, post a phpstan.org reproduction and add an expected output? I also don’t understand the note sblut range() function and how that’s related.

   On Wed, 11 Jul 2018 at 03:09, Alexey Kopytko ***@***.***> wrote: For this code: $allLines = range($input['startLine'], $input['endLine']);foreach ($allLines as $lineIn) { if (array_key_exists($lineIn, $this->example)) { // ... I'm getting: Parameter #1 <#1> $key of function array_key_exists expects int|string, float|int given. But there's a slight problem: range() may return an array of strings <http://php.net/manual/en/function.range.php> just as well. var_dump(range('c', 'a'));// outputs array('c', 'b', 'a') — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1201>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuFKDSLmtC3Qx01qG8UhL0G7spp3Uks5uFVAygaJpZM4VKVsc> .

   -- Ondřej Mirtes
3. sanmai commented on Jul 11, 2018

   

   sanmai

   on Jul 11, 2018

   Last edited by sanmai

   ContributorAuthor

   More actions

   I've added a link to the reproduction.

   range() returns array of either floats, ints, or strings, but PHPStan thinks it can only be of numbers.
4. adaamz commented on Jul 11, 2018

   

   adaamz

   on Jul 11, 2018

   Last edited by adaamz

   Contributor

   More actions

   @ondrejmirtes Dynamic return type extension really returns type array<int, int|flost>, see

   phpstan/src/Type/Php/RangeFunctionReturnTypeExtension.php

   Line 103 in 40ece9a

   return new ArrayType(new IntegerType(), new UnionType([new IntegerType(), new FloatType()]));
5. ondrejmirtes

   added this to the 0.10 milestone on Jul 11, 2018
6. ondrejmirtes

   added

   bug

   on Jul 11, 2018
7. sanmai

   added 2 commits that reference this issue on Jul 12, 2018

   Typehint for range() should suggest string[] where appropriate

   ...

   This issue will close once commit b147885 is merged into the 'master' branch.

   b147885

   Typehint for range() should suggest string[] where appropriate

   ...

   This issue will close once commit 8ff1322 is merged into the 'master' branch.

   8ff1322
8. ondrejmirtes commented on Feb 18, 2021

   

   ondrejmirtes

   on Feb 18, 2021

   Member

   More actions

   This is already fixed.
9. ondrejmirtes

   closed this as completedon Feb 18, 2021
10. github-actions commented on Apr 29, 2021

    

    github-actionsBot

    on Apr 29, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
11. github-actions

    locked as resolved and limited conversation to collaborators on Apr 29, 2021