Repository navigation
while-true-if-break: Variable might not be defined #11545
Description
Bug report
If a loop has no exit condition in the regular place, but a custom exit condition with if()..break, then phpstan fails to see a variable as defined that is defined inside the exit condition conditional block.
Similar to:
This problem might have the same technical cause, but it is a different test case, and hence it deserves its own issue - I think.
Code snippet that reproduces the problem
https://phpstan.org/r/1b3c4c9e-643a-4a50-90a9-875ad27af465
function foo(int $max): void {
$i = 0;
while (true) {
if ($i > $max) {
$result = 'done';
break;
}
++$i;
}
print $result; // Variable $result might not be defined.
}Expected output
No inspection warning.
Did PHPStan help you today? Did it make you happy in any way?
No response
Activity
MacGritsch commentedon Jan 5, 2025
Same issue with foreach
https://phpstan.org/r/00f146fe-cca5-4dc7-8677-20546a68386e
Add regression tests for #11545, #10245, #5919, #5477
Fix variable definedness after always-iterating loops with break
Add regression tests for #11545, #10245, phpstan#5919, phpstan#5477
VincentLanglet commentedon Mar 2, 2026
Just remove
strict-rulesoptionhttps://phpstan.org/r/2e89a4eb-02a0-49be-8cd0-bcdb160bdd97
Same for the for Loop.
It's about the polluteScopeWithLoopInitialAssignments and polluteScopeWithAlwaysIterableForeach options.
Other cases will be handled by phpstan/phpstan-src#5118
Add regression tests for #11545, #10245, phpstan#5919, phpstan#5477
phpstan-bot commentedon Mar 3, 2026
Closed via merging phpstan/phpstan-src#5118
github-actions commentedon Apr 4, 2026
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.