Skip to content

Defining Array Constants in PHP Traits Causes Errors When Using Class Constants as Keys or Values #11351

Closed
Closed
Defining Array Constants in PHP Traits Causes Errors When Using Class Constants as Keys or Values#11351
Labels
bug
Milestone
Easy fixes

Description

@zengboin
zengboin
opened on Jul 17, 2024

Bug report

When defining array constants within a PHP trait, if the array's keys or values utilize constants defined in the class that uses the trait, an error occurs. This issue hinders the ability to leverage class constants within trait-defined array constants, which can be a significant limitation in certain use cases.

Code snippet that reproduces the problem

https://phpstan.org/r/258a27f9-3c5a-4636-8f73-467efaeb5332

Expected output

OK

Did PHPStan help you today? Did it make you happy in any way?

No response

Activity

  1. ondrejmirtes
    added
    bug
    on Jul 17, 2024
  2. ondrejmirtes
    added this to the Easy fixes milestone on Jul 17, 2024

  3. phpstan-bot commented on Nov 30, 2024

    @phpstan-bot
    phpstan-bot
    on Nov 30, 2024
    Contributor

    @zengboin After the latest push in 2.0.x, PHPStan now reports different result with your code snippet:

    @@ @@
 PHP 8.3 (1 error)
 ==========
 
-7: Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<int|string, 'CA'> should have the same value.
+7: Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<'CA'> should have the same value.
 
 PHP 8.2 (2 errors)
 ==========
 
 7: Class constants with native types are supported only on PHP 8.3 and later.
-7: Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<int|string, 'CA'> should have the same value.
+7: Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<'CA'> should have the same value.
 
 PHP 7.2 – 8.1 (3 errors)
 ==========
 
 7: Class constants with native types are supported only on PHP 8.3 and later.
-7: Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<int|string, 'CA'> should have the same value.
+7: Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<'CA'> should have the same value.
 7: Constant is declared inside a trait but is only supported on PHP 8.2 and later.
    Full report

    PHP 8.3 (1 error)

    Line Error
    7 Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<'CA'> should have the same value.

    PHP 8.2 (2 errors)

    Line Error
    7 Class constants with native types are supported only on PHP 8.3 and later.
    7 Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<'CA'> should have the same value.

    PHP 7.2 – 8.1 (3 errors)

    Line Error
    7 Class constants with native types are supported only on PHP 8.3 and later.
    7 Constant A::A with value array{abc: 'CA'} overriding constant TA::A with different value non-empty-array<'CA'> should have the same value.
    7 Constant is declared inside a trait but is only supported on PHP 8.2 and later.

  4. laurinkeithdavis commented on Oct 16, 2025

    @laurinkeithdavis
    laurinkeithdavis
    on Oct 16, 2025

    Ugh, just ran into this one as well.

  5. laurinkeithdavis commented on Oct 16, 2025

    @laurinkeithdavis
    laurinkeithdavis
    on Oct 16, 2025

    Any workaround for this as it's we just made a major change that depends and this blocking our ability to deploy an urgent change.

  6. laurinkeithdavis commented on Oct 16, 2025

    @laurinkeithdavis
    laurinkeithdavis
    on Oct 16, 2025

    Also, why are there any errors that are "non-ignorable"?

  7. laurinkeithdavis commented on Oct 16, 2025

    @laurinkeithdavis
    laurinkeithdavis
    on Oct 16, 2025

    I just changed my constants into functions - annoying, but works for now.

  8. phpstan-bot
    added a commit that references this issue on Feb 28, 2026

    Fix false positive for trait array constants using class constants as…

    eeced60
  9. staabm
    added a commit that references this issue on Mar 1, 2026

    Fix phpstan/phpstan#11351: Defining Array Constants in PHP Traits Cau…

    9e0d021

  10. phpstan-bot commented on Mar 1, 2026

    @phpstan-bot
    phpstan-bot
    on Mar 1, 2026
    Contributor

    Closed via merging phpstan/phpstan-src#5115

  11. phpstan-bot
    closed this as completedin 9e0d021on Mar 1, 2026
  12. phpstan-bot
    added 2 commits that reference this issue on Mar 1, 2026

    Updated PHPStan to commit 9e0d02105d32760ad1dcb7547b9109ec74f5d73e

    9e0d021

    Updated PHPStan to commit e78c8bc93190c338d70d9b175291f1d3cc826e25

    e78c8bc

  13. github-actions commented on Apr 2, 2026

    @github-actions
    github-actionsBot
    on Apr 2, 2026 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  14. github-actions
    locked as resolved and limited conversation to collaborators on Apr 2, 2026
  15. phpstan-bot
    added a commit that references this issue on Apr 7, 2026

    Fix phpstan/phpstan#11351: Defining Array Constants in PHP Traits Cau…

    4b5dd5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions