more precise preg_match types #11222

Activity

1. ondrejmirtes commented on Jun 21, 2024

   

   ondrejmirtes

   on Jun 21, 2024

   Member

   More actions

   First thing we should is to cover preg_match_all and maybe others as well.

   👍React with 👍1Reacted by Michael Voříšek
2. ondrejmirtes

   added

   feature-request

   on Jun 21, 2024
3. phpstan-bot commented on Aug 1, 2024

   

   phpstan-bot

   on Aug 1, 2024

   Contributor

   More actions

   @staabm After the latest push in 1.12.x, PHPStan now reports different result with your code snippet:

   @@ @@
   -10: Expected type array{string, '£'|'€'}, actual: array<string>
   -13: Expected type array{string, numeric-string}, actual: array<string>
   -16: Expected type array{string, non-empty-string}, actual: array<string>
   -19: Expected type array{string, non-empty-string}, actual: array<string>
   -22: Expected type array{string, non-falsey-string}, actual: array<string>
   +10: Expected type array{string, '£'|'€'}, actual: array{string, non-empty-string}
   +22: Expected type array{string, non-falsey-string}, actual: array{string, non-empty-string}

   Full report

   Line	Error
   10	`Expected type array{string, '£'
   22	Expected type array{string, non-falsey-string}, actual: array{string, non-empty-string}
4. phpstan-bot commented on Aug 5, 2024

   

   phpstan-bot

   on Aug 5, 2024

   Contributor

   More actions

   @staabm After the latest push in 1.12.x, PHPStan now reports different result with your code snippet:

   @@ @@
   -10: Expected type array{string, '£'|'€'}, actual: array<string>
   -13: Expected type array{string, numeric-string}, actual: array<string>
   -16: Expected type array{string, non-empty-string}, actual: array<string>
   -19: Expected type array{string, non-empty-string}, actual: array<string>
   -22: Expected type array{string, non-falsey-string}, actual: array<string>
   +10: Expected type array{string, '£'|'€'}, actual: array{string, non-empty-string}
   +22: Expected type array{string, non-falsey-string}, actual: array{string, non-falsy-string}

   Full report

   Line	Error
   10	`Expected type array{string, '£'
   22	Expected type array{string, non-falsey-string}, actual: array{string, non-falsy-string}
5. ondrejmirtes

   closed this as completedin phpstan-src#3369on Aug 28, 2024
6. github-actions commented on Sep 29, 2024

   

   github-actionsBot

   on Sep 29, 2024 – with GitHub Actions

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
7. github-actions

   locked as resolved and limited conversation to collaborators on Sep 29, 2024