Conditional type in @param - Call to method Xxx::xxx() with true will always evaluate to true. #10337

Activity

1. ondrejmirtes

   added

   bug

   on Dec 31, 2023
2. ondrejmirtes

   added this to the Easy fixes milestone on Dec 31, 2023
3. phpstan-bot commented on Sep 19, 2024

   

   phpstan-bot

   on Sep 19, 2024

   Contributor

   More actions

   @mvorisek After the latest push in 2.0.x, PHPStan now reports different result with your code snippet:

   @@ @@
    24: Result of method App::callExit() (void) is used.
    28: Call to method App::callExit() with true will always evaluate to true.
    28: Result of method App::callExit() (void) is used.
   -37: Call to method class@anonymous/tmp.php:30::callExit() with true will always evaluate to true.
   -37: Result of method class@anonymous/tmp.php:30::callExit() (void) is used.
   +37: Call to method App@anonymous/tmp.php:30::callExit() with true will always evaluate to true.
   +37: Result of method App@anonymous/tmp.php:30::callExit() (void) is used.

   Full report

   Line	Error
   20	Call to method App::callExit() with true will always evaluate to true.
   24	Call to method App::callExit() with true will always evaluate to true.
   24	Result of method App::callExit() (void) is used.
   28	Call to method App::callExit() with true will always evaluate to true.
   28	Result of method App::callExit() (void) is used.
   37	Call to method App@anonymous/tmp.php:30::callExit() with true will always evaluate to true.
   37	Result of method App@anonymous/tmp.php:30::callExit() (void) is used.
4. phpstan-bot commented on Jul 21, 2025

   

   phpstan-bot

   on Jul 21, 2025

   Contributor

   More actions

   @mvorisek After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

   @@ @@
    20: Call to method App::callExit() with true will always evaluate to true.
   -24: Call to method App::callExit() with true will always evaluate to true.
   -24: Result of method App::callExit() (void) is used.
   -28: Call to method App::callExit() with true will always evaluate to true.
   -28: Result of method App::callExit() (void) is used.
   -37: Call to method App@anonymous/tmp.php:30::callExit() with true will always evaluate to true.
   -37: Result of method App@anonymous/tmp.php:30::callExit() (void) is used.
   +24: Unreachable statement - code above always terminates.

   Full report

   Line	Error
   20	Call to method App::callExit() with true will always evaluate to true.
   24	Unreachable statement - code above always terminates.
5. mvorisek commented on Jul 21, 2025

   

   mvorisek

   on Jul 21, 2025

   ContributorAuthor

   More actions

   @staabm phpstan/phpstan-src#4090 has broken this repro. It seems conditional never is wrongly assumed as always instead of maybe.
6. staabm commented on Jul 21, 2025

   

   staabm

   on Jul 21, 2025

   Contributor

   More actions

   I am not sure what you mean with broken...?

   It looks like after the first call which we know will never return everything is unreachable (which I think is expected).

   The initial error/bug you reported on line 20 is still there.

   IMO its now more correct than before (with the same bug in line20)

   👍React with 👍1Reacted by Michael Voříšek
7. mvorisek commented on Jul 21, 2025

   

   mvorisek

   on Jul 21, 2025

   Last edited by mvorisek

   ContributorAuthor

   More actions

   Thank you. I see you are correct, I was reading the "Unreachable statement - code above always terminates." error to be for a line 20, but it is for line 24 (thanks to line 23). This is expected. I will update my repro.
8. phpstan-bot commented on Mar 3, 2026

   

   phpstan-bot

   on Mar 3, 2026

   Contributor

   More actions

   Closed via merging phpstan/phpstan-src#5121
9. phpstan-bot

   closed this as completedon Mar 3, 2026
10. github-actions commented on Apr 4, 2026

    

    github-actionsBot

    on Apr 4, 2026 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
11. github-actions

    locked as resolved and limited conversation to collaborators on Apr 4, 2026