Run tests for PHP 8.4 #1493
Run tests for PHP 8.4 #1493
Conversation
|
@MarcelloDuarte thanks, I will review the failures |
|
@MarcelloDuarte please approve the potential fix |
|
@MarcelloDuarte psalm errors fixed 🤞 |
|
ping @MarcelloDuarte |
|
@MarcelloDuarte looks ready for release, wdyt? |
Jean85
left a comment
Jean85
left a comment
There was a problem hiding this comment.
LGTM, just a little nitpick.
| private function addErrorThrowingExampleToSuite(Resource $resource, Suite $suite, \Error $error) : void | ||
| { | ||
| $reflection = new ReflectionClass(ErrorSpecification::class); | ||
| /** @var ReflectionClass<Specification> $reflection */ |
There was a problem hiding this comment.
This PHPDoc seems superfluous, $reflection is already of this type (even more specific).
| /** @var ReflectionClass<Specification> $reflection */ |
There was a problem hiding this comment.
I had to add it to make psalm happy IIRC.
There was a problem hiding this comment.
I tested it locally and it worked fine. Maybe it was needed before other changes were done? BTW it's just redundant, so not a blocker for me.
|
@torchello thanks for this, and apologies for the silence... loads going on at my end. Do we need to update CHANGES-v8.md? |
|
@MarcelloDuarte good point! updated here. |
3 participants
Hopefully final step for 8.4 readiness (#1477).
@MarcelloDuarte could you please approve?