PHP 8.4 | Fix implicitly nullable parameters (8.x/main) #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a `null` default value, which are not explicitly declared as nullable. This commit fixes all found instances of that in the PHPSpec codebase. Includes updating the documentation to match (where relevant, i.e. only existing documentation has been touched). Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Contributor
Author
|
Similar to #1472, but for the main branch. Pulled separately as merging the 7.x fix into main would cause a lot of conflicts otherwise. |
Member
|
Merged 7.5 into main: #1482 Is there anything in this PR that's missing from the one that targeted 7.5? |
Contributor
Author
|
@jakzal I honestly can't remember, it was nearly four months ago when I created the PR. |
Contributor
Author
|
@jakzal Want me to rebase it to see if there's anything left after that ? |
MarcelloDuarte
approved these changes
May 12, 2025
Member
|
Thanks @jrfnl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a
nulldefault value, which are not explicitly declared as nullable.This commit fixes all found instances of that in the PHPSpec codebase.
Includes updating the documentation to match (where relevant, i.e. only existing documentation has been touched).
Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types