Fix/8.6.0 session failures - #2900
Conversation
PHP 8.6 is making session strict mode the default. This slightly changes the semantics around session ids. This fix mostly just allows us to disable strict mode for our tests which need to use their own ids to confirm locking functionality. Also we add some logic to the session handlers to keep track of if we need to generate an ID which should allow us to preserve lazy write semantics. Fixes #2898
f401cc1 to
5366285
Compare
remicollet
left a comment
remicollet
left a comment
There was a problem hiding this comment.
All tests passed. \o/
(tested with 8.4.23 and 8.6.0alpha2)
|
@michael-grunder is this fix related to In this case, does this affect old PHP versions when the configuration is changed ? In php.ini for 8.5
|
|
I confirm the problem Running PHP 8.4.23 with phpredis 6.3.0 with |
|
I didn't dig deeply into it but yes, I assume these test failures occur with strict mode enabled. That said most of the test failures have to do with the helper script attempting to inject a specific session id to look for the lock key, etc. in normal operation people just call session_start and let PHP pick the id |
2 participants
Fix session handler logic for PHP 8.6
Fixes #2898