Check type parameters of the type alias declaration

sheetalkamat · sheetalkamat · commit f8c3a550caab · 2016-10-21T16:45:58.000-07:00
Fixes microsoft#11166
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -17418,6 +17418,7 @@ namespace ts {
             checkGrammarDecorators(node) || checkGrammarModifiers(node);
 
             checkTypeNameIsReserved(node.name, Diagnostics.Type_alias_name_cannot_be_0);
+            checkTypeParameters(node.typeParameters);
             checkSourceElement(node.type);
         }
 
diff --git a/tests/baselines/reference/nounusedTypeParameterConstraint.errors.txt b/tests/baselines/reference/nounusedTypeParameterConstraint.errors.txt
diff --git a/tests/baselines/reference/nounusedTypeParameterConstraint.symbols b/tests/baselines/reference/nounusedTypeParameterConstraint.symbols
@@ -0,0 +1,15 @@
+=== tests/cases/compiler/bar.ts ===
+
+export interface IEventSourcedEntity { }
+>IEventSourcedEntity : Symbol(IEventSourcedEntity, Decl(bar.ts, 0, 0))
+
+=== tests/cases/compiler/test.ts ===
+import { IEventSourcedEntity } from "./bar";
+>IEventSourcedEntity : Symbol(IEventSourcedEntity, Decl(test.ts, 0, 8))
+
+export type DomainEntityConstructor<TEntity extends IEventSourcedEntity> = { new(): TEntity; };
+>DomainEntityConstructor : Symbol(DomainEntityConstructor, Decl(test.ts, 0, 44))
+>TEntity : Symbol(TEntity, Decl(test.ts, 1, 36))
+>IEventSourcedEntity : Symbol(IEventSourcedEntity, Decl(test.ts, 0, 8))
+>TEntity : Symbol(TEntity, Decl(test.ts, 1, 36))
+
diff --git a/tests/baselines/reference/nounusedTypeParameterConstraint.types b/tests/baselines/reference/nounusedTypeParameterConstraint.types
@@ -0,0 +1,15 @@
+=== tests/cases/compiler/bar.ts ===
+
+export interface IEventSourcedEntity { }
+>IEventSourcedEntity : IEventSourcedEntity
+
+=== tests/cases/compiler/test.ts ===
+import { IEventSourcedEntity } from "./bar";
+>IEventSourcedEntity : any
+
+export type DomainEntityConstructor<TEntity extends IEventSourcedEntity> = { new(): TEntity; };
+>DomainEntityConstructor : new () => TEntity
+>TEntity : TEntity
+>IEventSourcedEntity : IEventSourcedEntity
+>TEntity : TEntity
+
diff --git a/tests/baselines/reference/typeAliasDeclarationEmit.errors.txt b/tests/baselines/reference/typeAliasDeclarationEmit.errors.txt
@@ -0,0 +1,10 @@
+tests/cases/compiler/typeAliasDeclarationEmit.ts(4,37): error TS2314: Generic type 'callback' requires 1 type argument(s).
+
+
+==== tests/cases/compiler/typeAliasDeclarationEmit.ts (1 errors) ====
+    
+    export type callback<T> = () => T;
+    
+    export type CallbackArray<T extends callback> = () => T;
+                                        ~~~~~~~~
+!!! error TS2314: Generic type 'callback' requires 1 type argument(s).

Original file line number	Diff line number	Diff line change
`@@ -17418,6 +17418,7 @@ namespace ts {`
`17418`	`17418`	`checkGrammarDecorators(node) \|\| checkGrammarModifiers(node);`
`17419`	`17419`
`17420`	`17420`	`checkTypeNameIsReserved(node.name, Diagnostics.Type_alias_name_cannot_be_0);`
	`17421`	`+ checkTypeParameters(node.typeParameters);`
`17421`	`17422`	`checkSourceElement(node.type);`
`17422`	`17423`	`}`
`17423`	`17424`