Allow /* comments between < and JSX element name

RyanCavanaugh · RyanCavanaugh · commit f780d68499fc · 2015-09-28T16:11:10.000-07:00
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -3183,6 +3183,7 @@ namespace ts {
                     if (sourceFile.languageVariant !== LanguageVariant.JSX) {
                         return parseTypeAssertion();
                     }
+                    debugger;
                     if (lookAhead(nextTokenIsIdentifierOrKeyword)) {
                         return parseJsxElementOrSelfClosingElement(/*inExpressionContext*/ true);
                     }
diff --git a/src/compiler/scanner.ts b/src/compiler/scanner.ts
@@ -1361,7 +1361,9 @@ namespace ts {
                         if (text.charCodeAt(pos + 1) === CharacterCodes.equals) {
                             return pos += 2, token = SyntaxKind.LessThanEqualsToken;
                         }
-                        if (text.charCodeAt(pos + 1) === CharacterCodes.slash && languageVariant === LanguageVariant.JSX) {
+                        if (text.charCodeAt(pos + 1) === CharacterCodes.slash &&
+                                text.charCodeAt(pos + 2) !== CharacterCodes.asterisk &&
+                                languageVariant === LanguageVariant.JSX) {
                             return pos += 2, token = SyntaxKind.LessThanSlashToken;
                         }
                         return pos++, token = SyntaxKind.LessThanToken;
diff --git a/tests/baselines/reference/tsxParseTests2.js b/tests/baselines/reference/tsxParseTests2.js
@@ -0,0 +1,11 @@
+//// [tsxParseTests2.tsx]
+declare module JSX {
+	interface Element { }
+	interface IntrinsicElements { div; span; }
+}
+
+var x = </**/div></div>;
+
+
+//// [tsxParseTests2.jsx]
+var x = <div></div>;
diff --git a/tests/baselines/reference/tsxParseTests2.symbols b/tests/baselines/reference/tsxParseTests2.symbols
@@ -0,0 +1,18 @@
+=== tests/cases/conformance/jsx/tsxParseTests2.tsx ===
+declare module JSX {
+>JSX : Symbol(JSX, Decl(tsxParseTests2.tsx, 0, 0))
+
+	interface Element { }
+>Element : Symbol(Element, Decl(tsxParseTests2.tsx, 0, 20))
+
+	interface IntrinsicElements { div; span; }
+>IntrinsicElements : Symbol(IntrinsicElements, Decl(tsxParseTests2.tsx, 1, 22))
+>div : Symbol(div, Decl(tsxParseTests2.tsx, 2, 30))
+>span : Symbol(span, Decl(tsxParseTests2.tsx, 2, 35))
+}
+
+var x = </**/div></div>;
+>x : Symbol(x, Decl(tsxParseTests2.tsx, 5, 3))
+>div : Symbol(JSX.IntrinsicElements.div, Decl(tsxParseTests2.tsx, 2, 30))
+>div : Symbol(JSX.IntrinsicElements.div, Decl(tsxParseTests2.tsx, 2, 30))
+
diff --git a/tests/baselines/reference/tsxParseTests2.types b/tests/baselines/reference/tsxParseTests2.types
@@ -0,0 +1,19 @@
+=== tests/cases/conformance/jsx/tsxParseTests2.tsx ===
+declare module JSX {
+>JSX : any
+
+	interface Element { }
+>Element : Element
+
+	interface IntrinsicElements { div; span; }
+>IntrinsicElements : IntrinsicElements
+>div : any
+>span : any
+}
+
+var x = </**/div></div>;
+>x : JSX.Element
+></**/div></div> : JSX.Element
+>div : any
+>div : any
+
diff --git a/tests/cases/conformance/jsx/tsxParseTests2.tsx b/tests/cases/conformance/jsx/tsxParseTests2.tsx
@@ -0,0 +1,8 @@
+//@filename: file.tsx
+//@jsx: preserve
+declare module JSX {
+	interface Element { }
+	interface IntrinsicElements { div; span; }
+}
+
+var x = </**/div></div>;

Original file line number	Diff line number	Diff line change
`@@ -3183,6 +3183,7 @@ namespace ts {`
`3183`	`3183`	`if (sourceFile.languageVariant !== LanguageVariant.JSX) {`
`3184`	`3184`	`return parseTypeAssertion();`
`3185`	`3185`	`}`
	`3186`	`+ debugger;`
`3186`	`3187`	`if (lookAhead(nextTokenIsIdentifierOrKeyword)) {`
`3187`	`3188`	`return parseJsxElementOrSelfClosingElement(/inExpressionContext/ true);`
`3188`	`3189`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1361,7 +1361,9 @@ namespace ts {`
`1361`	`1361`	`if (text.charCodeAt(pos + 1) === CharacterCodes.equals) {`
`1362`	`1362`	`return pos += 2, token = SyntaxKind.LessThanEqualsToken;`
`1363`	`1363`	`}`
`1364`		`- if (text.charCodeAt(pos + 1) === CharacterCodes.slash && languageVariant === LanguageVariant.JSX) {`
	`1364`	`+ if (text.charCodeAt(pos + 1) === CharacterCodes.slash &&`
	`1365`	`+ text.charCodeAt(pos + 2) !== CharacterCodes.asterisk &&`
	`1366`	`+ languageVariant === LanguageVariant.JSX) {`
`1365`	`1367`	`return pos += 2, token = SyntaxKind.LessThanSlashToken;`
`1366`	`1368`	`}`
`1367`	`1369`	`return pos++, token = SyntaxKind.LessThanToken;`