Fix for microsoft#2268 createDiagnosticCollection should be @internal

mihailik · mihailik · commit dc451b0f69ed · 2015-03-09T14:05:53.000Z
DiagnosticsCollection interface is marked @internal in [src/compiler/types.ts](https://github.com/Microsoft/TypeScript/blob/c6cd57d18c85e59b2fbe9d316725748a0af8ac2b/src/compiler/types.ts#L1761), so this should be @internal too. Otherwise it causes compilation errors whenever the generated type definitions for LS is used. See microsoft#2268 for more details.
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -1207,6 +1207,7 @@ module ts {
         }
     }
 
+    // @internal
     export function createDiagnosticCollection(): DiagnosticCollection {
         var nonFileDiagnostics: Diagnostic[] = [];
         var fileDiagnostics: Map<Diagnostic[]> = {};
@@ -1336,4 +1337,4 @@ module ts {
             s.replace(nonAsciiCharacters, c => get16BitUnicodeEscapeSequence(c.charCodeAt(0))) :
             s;
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -1207,6 +1207,7 @@ module ts {`
`1207`	`1207`	`}`
`1208`	`1208`	`}`
`1209`	`1209`
	`1210`	`+ // @internal`
`1210`	`1211`	`export function createDiagnosticCollection(): DiagnosticCollection {`
`1211`	`1212`	`var nonFileDiagnostics: Diagnostic[] = [];`
`1212`	`1213`	`var fileDiagnostics: Map<Diagnostic[]> = {};`
`@@ -1336,4 +1337,4 @@ module ts {`
`1336`	`1337`	`s.replace(nonAsciiCharacters, c => get16BitUnicodeEscapeSequence(c.charCodeAt(0))) :`
`1337`	`1338`	`s;`
`1338`	`1339`	`}`
`1339`		`-}`
	`1340`	`+}`