Ensure const enum members with same value have same type identity

ahejlsberg · ahejlsberg · commit d37d50afb0a8 · 2016-07-01T09:18:43.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -3667,12 +3667,23 @@ namespace ts {
             return links.declaredType;
         }
 
+        function createEnumType(symbol: Symbol): Type {
+            const type = createType(TypeFlags.Enum);
+            type.symbol = symbol;
+            return type;
+        }
+
+        function getEnumMemberType(symbol: Symbol): Type {
+            const links = getSymbolLinks(getParentOfSymbol(symbol));
+            const map = links.enumMemberTypes || (links.enumMemberTypes = {});
+            const value = "" + getEnumMemberValue(<EnumMember>symbol.valueDeclaration);
+            return map[value] || (map[value] = createEnumType(symbol));
+        }
+
         function getDeclaredTypeOfEnum(symbol: Symbol): Type {
             const links = getSymbolLinks(symbol);
             if (!links.declaredType) {
-                const type = createType(TypeFlags.Enum);
-                type.symbol = symbol;
-                links.declaredType = type;
+                links.declaredType = symbol.flags & SymbolFlags.EnumMember ? getEnumMemberType(symbol) : createEnumType(symbol);
             }
             return links.declaredType;
         }
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -2136,6 +2136,7 @@ namespace ts {
         isDeclarationWithCollidingName?: boolean;    // True if symbol is block scoped redeclaration
         bindingElement?: BindingElement;    // Binding element associated with property symbol
         exportsSomeValue?: boolean;         // True if module exports some value (not just types)
+        enumMemberTypes?: Map<Type>;        // Enum member types indexed by enum value
     }
 
     /* @internal */

Original file line number	Diff line number	Diff line change
`@@ -2136,6 +2136,7 @@ namespace ts {`
`2136`	`2136`	`isDeclarationWithCollidingName?: boolean; // True if symbol is block scoped redeclaration`
`2137`	`2137`	`bindingElement?: BindingElement; // Binding element associated with property symbol`
`2138`	`2138`	`exportsSomeValue?: boolean; // True if module exports some value (not just types)`
	`2139`	`+ enumMemberTypes?: Map<Type>; // Enum member types indexed by enum value`
`2139`	`2140`	`}`
`2140`	`2141`
`2141`	`2142`	`/* @internal */`