Merge pull request microsoft#10789 from Microsoft/re_export_shorthand

Andy · web-flow · commit b5d2707f728b · 2016-09-09T06:24:49.000-07:00
A shorthand ambient module should be considered as possibly exporting a value
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -1043,7 +1043,7 @@ namespace ts {
             const moduleSymbol = resolveExternalModuleName(node, (<ImportDeclaration>node.parent).moduleSpecifier);
 
             if (moduleSymbol) {
-                const exportDefaultSymbol = isShorthandAmbientModule(moduleSymbol.valueDeclaration) ?
+                const exportDefaultSymbol = isShorthandAmbientModuleSymbol(moduleSymbol) ?
                     moduleSymbol :
                     moduleSymbol.exports["export="] ?
                         getPropertyOfType(getTypeOfSymbol(moduleSymbol.exports["export="]), "default") :
@@ -1119,7 +1119,7 @@ namespace ts {
             if (targetSymbol) {
                 const name = specifier.propertyName || specifier.name;
                 if (name.text) {
-                    if (isShorthandAmbientModule(moduleSymbol.valueDeclaration)) {
+                    if (isShorthandAmbientModuleSymbol(moduleSymbol)) {
                         return moduleSymbol;
                     }
 
@@ -3382,7 +3382,7 @@ namespace ts {
         function getTypeOfFuncClassEnumModule(symbol: Symbol): Type {
             const links = getSymbolLinks(symbol);
             if (!links.type) {
-                if (symbol.valueDeclaration.kind === SyntaxKind.ModuleDeclaration && isShorthandAmbientModule(<ModuleDeclaration>symbol.valueDeclaration)) {
+                if (symbol.valueDeclaration.kind === SyntaxKind.ModuleDeclaration && isShorthandAmbientModuleSymbol(symbol)) {
                     links.type = anyType;
                 }
                 else {
@@ -18371,8 +18371,8 @@ namespace ts {
 
         function moduleExportsSomeValue(moduleReferenceExpression: Expression): boolean {
             let moduleSymbol = resolveExternalModuleName(moduleReferenceExpression.parent, moduleReferenceExpression);
-            if (!moduleSymbol) {
-                // module not found - be conservative
+            if (!moduleSymbol || isShorthandAmbientModuleSymbol(moduleSymbol)) {
+                // If the module is not found or is shorthand, assume that it may export a value.
                 return true;
             }
 
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -414,7 +414,11 @@ namespace ts {
             ((<ModuleDeclaration>node).name.kind === SyntaxKind.StringLiteral || isGlobalScopeAugmentation(<ModuleDeclaration>node));
     }
 
-    export function isShorthandAmbientModule(node: Node): boolean {
+    export function isShorthandAmbientModuleSymbol(moduleSymbol: Symbol): boolean {
+        return isShorthandAmbientModule(moduleSymbol.valueDeclaration);
+    }
+
+    function isShorthandAmbientModule(node: Node): boolean {
         // The only kind of module that can be missing a body is a shorthand ambient module.
         return node.kind === SyntaxKind.ModuleDeclaration && (!(<ModuleDeclaration>node).body);
     }
diff --git a/tests/baselines/reference/ambientShorthand_reExport.js b/tests/baselines/reference/ambientShorthand_reExport.js
@@ -22,6 +22,10 @@ var jquery_1 = require("jquery");
 exports.x = jquery_1.x;
 //// [reExportAll.js]
 "use strict";
+function __export(m) {
+    for (var p in m) if (!exports.hasOwnProperty(p)) exports[p] = m[p];
+}
+__export(require("jquery"));
 //// [reExportUser.js]
 "use strict";
 var reExportX_1 = require("./reExportX");

Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,11 @@ namespace ts {`
`414`	`414`	`((<ModuleDeclaration>node).name.kind === SyntaxKind.StringLiteral \|\| isGlobalScopeAugmentation(<ModuleDeclaration>node));`
`415`	`415`	`}`
`416`	`416`
`417`		`- export function isShorthandAmbientModule(node: Node): boolean {`
	`417`	`+ export function isShorthandAmbientModuleSymbol(moduleSymbol: Symbol): boolean {`
	`418`	`+ return isShorthandAmbientModule(moduleSymbol.valueDeclaration);`
	`419`	`+ }`
	`420`	`+`
	`421`	`+ function isShorthandAmbientModule(node: Node): boolean {`
`418`	`422`	`// The only kind of module that can be missing a body is a shorthand ambient module.`
`419`	`423`	`return node.kind === SyntaxKind.ModuleDeclaration && (!(<ModuleDeclaration>node).body);`
`420`	`424`	`}`