Do not emit declarations for javascript files

sheetalkamat · sheetalkamat · commit 94a647b72b48 · 2015-10-30T11:36:39.000-07:00
diff --git a/src/compiler/declarationEmitter.ts b/src/compiler/declarationEmitter.ts
@@ -33,7 +33,9 @@ namespace ts {
     export function getDeclarationDiagnostics(host: EmitHost, resolver: EmitResolver, targetSourceFile: SourceFile): Diagnostic[] {
         let diagnostics: Diagnostic[] = [];
         let { declarationFilePath } = getEmitFileNames(targetSourceFile, host);
-        emitDeclarations(host, resolver, diagnostics, declarationFilePath, targetSourceFile);
+        if (declarationFilePath) {
+            emitDeclarations(host, resolver, diagnostics, declarationFilePath, targetSourceFile);
+        }
         return diagnostics;
     }
 
@@ -105,7 +107,7 @@ namespace ts {
             // Emit references corresponding to this file
             let emittedReferencedFiles: SourceFile[] = [];
             forEach(host.getSourceFiles(), sourceFile => {
-                if (!isExternalModuleOrDeclarationFile(sourceFile)) {
+                if (!isExternalModuleOrDeclarationFile(sourceFile) && !isJavaScript(sourceFile.fileName)) {
                     // Check what references need to be added
                     if (!compilerOptions.noResolve) {
                         forEach(sourceFile.referencedFiles, fileReference => {
@@ -1590,9 +1592,17 @@ namespace ts {
         }
 
         function writeReferencePath(referencedFile: SourceFile) {
-            let declFileName = referencedFile.flags & NodeFlags.DeclarationFile
-                ? referencedFile.fileName // Declaration file, use declaration file name
-                :  getEmitFileNames(referencedFile, host).declarationFilePath; // declaration file name
+            let declFileName: string;
+            if (referencedFile.flags & NodeFlags.DeclarationFile) {
+                // Declaration file, use declaration file name
+                declFileName = referencedFile.fileName;
+            }
+            else {
+                // declaration file name
+                let { declarationFilePath, jsFilePath } = getEmitFileNames(referencedFile, host);
+                Debug.assert(!!declarationFilePath || isJavaScript(referencedFile.fileName), "Declaration file is not present only for javascript files");
+                declFileName = declarationFilePath || jsFilePath;
+            }
 
             declFileName = getRelativePathToDirectoryOrUrl(
                 getDirectoryPath(normalizeSlashes(declarationFilePath)),
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -8158,7 +8158,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, Promi
                 emitJavaScript(jsFilePath, sourceMapFilePath, sourceFile);
             }
 
-            if (compilerOptions.declaration) {
+            if (declarationFilePath) {
                 emitSkipped = writeDeclarationFile(declarationFilePath, sourceFile, host, resolver, diagnostics) || emitSkipped;
             }
 
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -1272,7 +1272,7 @@ namespace ts {
                             if (sourceMapFilePath) {
                                 emitFilesSeen[sourceMapFilePath] = [file];
                             }
-                            if (options.declaration) {
+                            if (declarationFilePath) {
                                 emitFilesSeen[declarationFilePath] = [file];
                             }
                         }
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -1797,7 +1797,7 @@ namespace ts {
                 return {
                     jsFilePath,
                     sourceMapFilePath: getSourceMapFilePath(jsFilePath, options),
-                    declarationFilePath: getDeclarationEmitFilePath(jsFilePath, options)
+                    declarationFilePath: !isJavaScript(sourceFile.fileName) ? getDeclarationEmitFilePath(jsFilePath, options) : undefined
                 };
             }
             else if (options.outFile || options.out) {
diff --git a/tests/baselines/reference/jsFileCompilationDuplicateVariable.js b/tests/baselines/reference/jsFileCompilationDuplicateVariable.js
@@ -13,4 +13,3 @@ var x = "hello"; // No error is recorded here and declaration file will show thi
 
 //// [out.d.ts]
 declare var x: number;
-declare var x: number;
diff --git a/tests/baselines/reference/jsFileCompilationDuplicateVariableErrorReported.js b/tests/baselines/reference/jsFileCompilationDuplicateVariableErrorReported.js
@@ -13,4 +13,3 @@ var x = 10; // Error reported so no declaration file generated?
 
 //// [out.d.ts]
 declare var x: string;
-declare var x: string;
diff --git a/tests/baselines/reference/jsFileCompilationEmitDeclarations.js b/tests/baselines/reference/jsFileCompilationEmitDeclarations.js
@@ -22,4 +22,3 @@ function foo() {
 //// [out.d.ts]
 declare class c {
 }
-declare function foo(): void;
diff --git a/tests/baselines/reference/jsFileCompilationEmitTrippleSlashReference.js b/tests/baselines/reference/jsFileCompilationEmitTrippleSlashReference.js
@@ -29,5 +29,3 @@ function foo() {
 //// [out.d.ts]
 declare class c {
 }
-declare function bar(): void;
-declare function foo(): void;
diff --git a/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithNoOut.errors.txt b/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithNoOut.errors.txt
@@ -8,7 +8,7 @@ error TS5055: Cannot write file 'tests/cases/compiler/c.js' which is one of the
     
 ==== tests/cases/compiler/b.ts (0 errors) ====
     /// <reference path="c.js"/>
-    // error on above reference path when emitting declarations
+    // b.d.ts should have c.js as the reference path since we dont emit declarations for js files
     function foo() {
     }
     
diff --git a/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithNoOut.js b/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithNoOut.js
@@ -6,7 +6,7 @@ class c {
 
 //// [b.ts]
 /// <reference path="c.js"/>
-// error on above reference path when emitting declarations
+// b.d.ts should have c.js as the reference path since we dont emit declarations for js files
 function foo() {
 }
 
@@ -22,16 +22,14 @@ var c = (function () {
 })();
 //// [b.js]
 /// <reference path="c.js"/>
-// error on above reference path when emitting declarations
+// b.d.ts should have c.js as the reference path since we dont emit declarations for js files
 function foo() {
 }
 
 
 //// [a.d.ts]
 declare class c {
 }
-//// [c.d.ts]
-declare function bar(): void;
 //// [b.d.ts]
-/// <reference path="c.d.ts" />
+/// <reference path="c.js" />
 declare function foo(): void;
diff --git a/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOut.js b/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOut.js
@@ -31,5 +31,4 @@ function foo() {
 //// [out.d.ts]
 declare class c {
 }
-declare function bar(): void;
 declare function foo(): void;
diff --git a/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOutDir.symbols b/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOutDir.symbols
@@ -0,0 +1,16 @@
+=== tests/cases/compiler/a.ts ===
+class c {
+>c : Symbol(c, Decl(a.ts, 0, 0))
+}
+
+=== tests/cases/compiler/b.ts ===
+/// <reference path="c.js"/>
+// b.d.ts should have c.js as the reference path since we dont emit declarations for js files
+function foo() {
+>foo : Symbol(foo, Decl(b.ts, 0, 0))
+}
+
+=== tests/cases/compiler/c.js ===
+function bar() {
+>bar : Symbol(bar, Decl(c.js, 0, 0))
+}
diff --git a/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOutDir.types b/tests/baselines/reference/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOutDir.types
@@ -0,0 +1,16 @@
+=== tests/cases/compiler/a.ts ===
+class c {
+>c : c
+}
+
+=== tests/cases/compiler/b.ts ===
+/// <reference path="c.js"/>
+// b.d.ts should have c.js as the reference path since we dont emit declarations for js files
+function foo() {
+>foo : () => void
+}
+
+=== tests/cases/compiler/c.js ===
+function bar() {
+>bar : () => void
+}
diff --git a/tests/baselines/reference/jsFileCompilationLetDeclarationOrder.js b/tests/baselines/reference/jsFileCompilationLetDeclarationOrder.js
@@ -17,5 +17,4 @@ a = 10;
 
 
 //// [out.d.ts]
-declare let a: number;
 declare let b: number;
diff --git a/tests/baselines/reference/jsFileCompilationLetDeclarationOrder2.js b/tests/baselines/reference/jsFileCompilationLetDeclarationOrder2.js
@@ -17,4 +17,3 @@ b = 30;
 
 //// [out.d.ts]
 declare let b: number;
-declare let a: number;
diff --git a/tests/baselines/reference/project/jsFileCompilationDifferentNamesNotSpecifiedWithAllowJs/amd/test.d.ts b/tests/baselines/reference/project/jsFileCompilationDifferentNamesNotSpecifiedWithAllowJs/amd/test.d.ts
@@ -1,2 +1 @@
 declare var test: number;
-declare var test2: number;
diff --git a/tests/baselines/reference/project/jsFileCompilationDifferentNamesNotSpecifiedWithAllowJs/node/test.d.ts b/tests/baselines/reference/project/jsFileCompilationDifferentNamesNotSpecifiedWithAllowJs/node/test.d.ts
@@ -1,2 +1 @@
 declare var test: number;
-declare var test2: number;
diff --git a/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecifiedWithAllowJs/amd/test.d.ts b/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecifiedWithAllowJs/amd/test.d.ts
@@ -1,2 +1 @@
 declare var test: number;
-declare var test2: number;
diff --git a/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecifiedWithAllowJs/node/test.d.ts b/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecifiedWithAllowJs/node/test.d.ts
@@ -1,2 +1 @@
 declare var test: number;
-declare var test2: number;
diff --git a/tests/cases/compiler/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithNoOut.ts b/tests/cases/compiler/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithNoOut.ts
@@ -6,7 +6,7 @@ class c {
 
 // @filename: b.ts
 /// <reference path="c.js"/>
-// error on above reference path when emitting declarations
+// b.d.ts should have c.js as the reference path since we dont emit declarations for js files
 function foo() {
 }
 
diff --git a/tests/cases/compiler/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOutDir.ts b/tests/cases/compiler/jsFileCompilationErrorOnDeclarationsWithJsFileReferenceWithOutDir.ts
@@ -0,0 +1,16 @@
+// @allowJs: true
+// @declaration: true
+// @outDir: outDir
+// @filename: a.ts
+class c {
+}
+
+// @filename: b.ts
+/// <reference path="c.js"/>
+// b.d.ts should have c.js as the reference path since we dont emit declarations for js files
+function foo() {
+}
+
+// @filename: c.js
+function bar() {
+}

Original file line number	Diff line number	Diff line change
`@@ -8158,7 +8158,7 @@ var __awaiter = (this && this.__awaiter) \|\| function (thisArg, _arguments, Promi`
`8158`	`8158`	`emitJavaScript(jsFilePath, sourceMapFilePath, sourceFile);`
`8159`	`8159`	`}`
`8160`	`8160`
`8161`		`- if (compilerOptions.declaration) {`
	`8161`	`+ if (declarationFilePath) {`
`8162`	`8162`	`emitSkipped = writeDeclarationFile(declarationFilePath, sourceFile, host, resolver, diagnostics) \|\| emitSkipped;`
`8163`	`8163`	`}`
`8164`	`8164`
Original file line number	Diff line number	Diff line change
`@@ -1272,7 +1272,7 @@ namespace ts {`
`1272`	`1272`	`if (sourceMapFilePath) {`
`1273`	`1273`	`emitFilesSeen[sourceMapFilePath] = [file];`
`1274`	`1274`	`}`
`1275`		`- if (options.declaration) {`
	`1275`	`+ if (declarationFilePath) {`
`1276`	`1276`	`emitFilesSeen[declarationFilePath] = [file];`
`1277`	`1277`	`}`
`1278`	`1278`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1797,7 +1797,7 @@ namespace ts {`
`1797`	`1797`	`return {`
`1798`	`1798`	`jsFilePath,`
`1799`	`1799`	`sourceMapFilePath: getSourceMapFilePath(jsFilePath, options),`
`1800`		`- declarationFilePath: getDeclarationEmitFilePath(jsFilePath, options)`
	`1800`	`+ declarationFilePath: !isJavaScript(sourceFile.fileName) ? getDeclarationEmitFilePath(jsFilePath, options) : undefined`
`1801`	`1801`	`};`
`1802`	`1802`	`}`
`1803`	`1803`	`else if (options.outFile \|\| options.out) {`
Original file line number	Diff line number	Diff line change
`@@ -13,4 +13,3 @@ var x = "hello"; // No error is recorded here and declaration file will show thi`
`13`	`13`
`14`	`14`	`//// [out.d.ts]`
`15`	`15`	`declare var x: number;`
`16`		`-declare var x: number;`
Original file line number	Diff line number	Diff line change
`@@ -13,4 +13,3 @@ var x = 10; // Error reported so no declaration file generated?`
`13`	`13`
`14`	`14`	`//// [out.d.ts]`
`15`	`15`	`declare var x: string;`
`16`		`-declare var x: string;`
Original file line number	Diff line number	Diff line change
`@@ -22,4 +22,3 @@ function foo() {`
`22`	`22`	`//// [out.d.ts]`
`23`	`23`	`declare class c {`
`24`	`24`	`}`
`25`		`-declare function foo(): void;`
Original file line number	Diff line number	Diff line change
`@@ -29,5 +29,3 @@ function foo() {`
`29`	`29`	`//// [out.d.ts]`
`30`	`30`	`declare class c {`
`31`	`31`	`}`
`32`		`-declare function bar(): void;`
`33`		`-declare function foo(): void;`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ error TS5055: Cannot write file 'tests/cases/compiler/c.js' which is one of the`
`8`	`8`
`9`	`9`	`==== tests/cases/compiler/b.ts (0 errors) ====`
`10`	`10`	`/// <reference path="c.js"/>`
`11`		`- // error on above reference path when emitting declarations`
	`11`	`+ // b.d.ts should have c.js as the reference path since we dont emit declarations for js files`
`12`	`12`	`function foo() {`
`13`	`13`	`}`
`14`	`14`