Add missing visitNode call to object literal members

Yogu · Yogu · commit 903d137cea1d · 2017-08-13T15:11:48.000+02:00
Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children. Fixes microsoft#16765.
diff --git a/src/compiler/transformers/esnext.ts b/src/compiler/transformers/esnext.ts
@@ -158,8 +158,8 @@ namespace ts {
             return visitEachChild(node, visitor, context);
         }
 
-        function chunkObjectLiteralElements(elements: ReadonlyArray<ObjectLiteralElement>): Expression[] {
-            let chunkObject: (ShorthandPropertyAssignment | PropertyAssignment)[];
+        function chunkObjectLiteralElements(elements: ReadonlyArray<ObjectLiteralElementLike>): Expression[] {
+            let chunkObject: ObjectLiteralElementLike[];
             const objects: Expression[] = [];
             for (const e of elements) {
                 if (e.kind === SyntaxKind.SpreadAssignment) {
@@ -179,7 +179,7 @@ namespace ts {
                         chunkObject.push(createPropertyAssignment(p.name, visitNode(p.initializer, visitor, isExpression)));
                     }
                     else {
-                        chunkObject.push(e as ShorthandPropertyAssignment);
+                        chunkObject.push(visitNode(e, visitor, isObjectLiteralElementLike));
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -158,8 +158,8 @@ namespace ts {`
`158`	`158`	`return visitEachChild(node, visitor, context);`
`159`	`159`	`}`
`160`	`160`
`161`		`- function chunkObjectLiteralElements(elements: ReadonlyArray<ObjectLiteralElement>): Expression[] {`
`162`		`- let chunkObject: (ShorthandPropertyAssignment \| PropertyAssignment)[];`
	`161`	`+ function chunkObjectLiteralElements(elements: ReadonlyArray<ObjectLiteralElementLike>): Expression[] {`
	`162`	`+ let chunkObject: ObjectLiteralElementLike[];`
`163`	`163`	`const objects: Expression[] = [];`
`164`	`164`	`for (const e of elements) {`
`165`	`165`	`if (e.kind === SyntaxKind.SpreadAssignment) {`
`@@ -179,7 +179,7 @@ namespace ts {`
`179`	`179`	`chunkObject.push(createPropertyAssignment(p.name, visitNode(p.initializer, visitor, isExpression)));`
`180`	`180`	`}`
`181`	`181`	`else {`
`182`		`- chunkObject.push(e as ShorthandPropertyAssignment);`
	`182`	`+ chunkObject.push(visitNode(e, visitor, isObjectLiteralElementLike));`
`183`	`183`	`}`
`184`	`184`	`}`
`185`	`185`	`}`