Merge pull request microsoft#2086 from Microsoft/ofKeywordClassification

JsonFreeman · JsonFreeman · commit 791e91351c28 · 2015-02-20T12:29:41.000-08:00
Of keyword classification
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -142,7 +142,7 @@ module ts {
         StringKeyword,
         SymbolKeyword,
         TypeKeyword,
-        OfKeyword,
+        OfKeyword, // LastKeyword and LastToken
         // Parse tree nodes
 
         // Names
@@ -269,7 +269,7 @@ module ts {
         FirstPunctuation = OpenBraceToken,
         LastPunctuation = CaretEqualsToken,
         FirstToken = Unknown,
-        LastToken = TypeKeyword,
+        LastToken = OfKeyword,
         FirstTriviaToken = SingleLineCommentTrivia,
         LastTriviaToken = ConflictMarkerTrivia,
         FirstLiteralToken = NumericLiteral,
diff --git a/src/services/formatting/rules.ts b/src/services/formatting/rules.ts
@@ -464,6 +464,9 @@ module ts.formatting {
                 // "in" keyword in for (var x in []) { }
                 case SyntaxKind.ForInStatement:
                     return context.currentTokenSpan.kind === SyntaxKind.InKeyword || context.nextTokenSpan.kind === SyntaxKind.InKeyword;
+                // Technically, "of" is not a binary operator, but format it the same way as "in"
+                case SyntaxKind.ForOfStatement:
+                    return context.currentTokenSpan.kind === SyntaxKind.OfKeyword || context.nextTokenSpan.kind === SyntaxKind.OfKeyword;
             }
             return false;
         }
diff --git a/src/services/formatting/tokenRange.ts b/src/services/formatting/tokenRange.ts
@@ -126,7 +126,7 @@ module ts.formatting {
             static AnyIncludingMultilineComments = TokenRange.FromTokens(TokenRange.Any.GetTokens().concat([SyntaxKind.MultiLineCommentTrivia]));
             static Keywords = TokenRange.FromRange(SyntaxKind.FirstKeyword, SyntaxKind.LastKeyword);
             static BinaryOperators = TokenRange.FromRange(SyntaxKind.FirstBinaryOperator, SyntaxKind.LastBinaryOperator);
-            static BinaryKeywordOperators = TokenRange.FromTokens([SyntaxKind.InKeyword, SyntaxKind.InstanceOfKeyword]);
+            static BinaryKeywordOperators = TokenRange.FromTokens([SyntaxKind.InKeyword, SyntaxKind.InstanceOfKeyword, SyntaxKind.OfKeyword]);
             static UnaryPrefixOperators = TokenRange.FromTokens([SyntaxKind.PlusPlusToken, SyntaxKind.MinusMinusToken, SyntaxKind.TildeToken, SyntaxKind.ExclamationToken]);
             static UnaryPrefixExpressions = TokenRange.FromTokens([SyntaxKind.NumericLiteral, SyntaxKind.Identifier, SyntaxKind.OpenParenToken, SyntaxKind.OpenBracketToken, SyntaxKind.OpenBraceToken, SyntaxKind.ThisKeyword, SyntaxKind.NewKeyword]);
             static UnaryPreincrementExpressions = TokenRange.FromTokens([SyntaxKind.Identifier, SyntaxKind.OpenParenToken, SyntaxKind.ThisKeyword, SyntaxKind.NewKeyword]);
diff --git a/tests/baselines/reference/APISample_compile.js b/tests/baselines/reference/APISample_compile.js
@@ -285,7 +285,7 @@ declare module "typescript" {
         FirstPunctuation = 14,
         LastPunctuation = 63,
         FirstToken = 0,
-        LastToken = 121,
+        LastToken = 122,
         FirstTriviaToken = 2,
         LastTriviaToken = 6,
         FirstLiteralToken = 7,
diff --git a/tests/baselines/reference/APISample_compile.types b/tests/baselines/reference/APISample_compile.types
@@ -871,7 +871,7 @@ declare module "typescript" {
         FirstToken = 0,
 >FirstToken : SyntaxKind
 
-        LastToken = 121,
+        LastToken = 122,
 >LastToken : SyntaxKind
 
         FirstTriviaToken = 2,
diff --git a/tests/baselines/reference/APISample_linter.js b/tests/baselines/reference/APISample_linter.js
@@ -316,7 +316,7 @@ declare module "typescript" {
         FirstPunctuation = 14,
         LastPunctuation = 63,
         FirstToken = 0,
-        LastToken = 121,
+        LastToken = 122,
         FirstTriviaToken = 2,
         LastTriviaToken = 6,
         FirstLiteralToken = 7,
diff --git a/tests/baselines/reference/APISample_linter.types b/tests/baselines/reference/APISample_linter.types
@@ -1015,7 +1015,7 @@ declare module "typescript" {
         FirstToken = 0,
 >FirstToken : SyntaxKind
 
-        LastToken = 121,
+        LastToken = 122,
 >LastToken : SyntaxKind
 
         FirstTriviaToken = 2,
diff --git a/tests/baselines/reference/APISample_transform.js b/tests/baselines/reference/APISample_transform.js
@@ -317,7 +317,7 @@ declare module "typescript" {
         FirstPunctuation = 14,
         LastPunctuation = 63,
         FirstToken = 0,
-        LastToken = 121,
+        LastToken = 122,
         FirstTriviaToken = 2,
         LastTriviaToken = 6,
         FirstLiteralToken = 7,
diff --git a/tests/baselines/reference/APISample_transform.types b/tests/baselines/reference/APISample_transform.types
@@ -967,7 +967,7 @@ declare module "typescript" {
         FirstToken = 0,
 >FirstToken : SyntaxKind
 
-        LastToken = 121,
+        LastToken = 122,
 >LastToken : SyntaxKind
 
         FirstTriviaToken = 2,
diff --git a/tests/baselines/reference/APISample_watcher.js b/tests/baselines/reference/APISample_watcher.js
@@ -354,7 +354,7 @@ declare module "typescript" {
         FirstPunctuation = 14,
         LastPunctuation = 63,
         FirstToken = 0,
-        LastToken = 121,
+        LastToken = 122,
         FirstTriviaToken = 2,
         LastTriviaToken = 6,
         FirstLiteralToken = 7,
diff --git a/tests/baselines/reference/APISample_watcher.types b/tests/baselines/reference/APISample_watcher.types
@@ -1140,7 +1140,7 @@ declare module "typescript" {
         FirstToken = 0,
 >FirstToken : SyntaxKind
 
-        LastToken = 121,
+        LastToken = 122,
 >LastToken : SyntaxKind
 
         FirstTriviaToken = 2,
diff --git a/tests/cases/fourslash/formattingForOfKeyword.ts b/tests/cases/fourslash/formattingForOfKeyword.ts
@@ -0,0 +1,8 @@
+/// <reference path='fourslash.ts' />
+
+/////**/for ([]of[]) { }
+
+
+format.document();
+goTo.marker();
+verify.currentLineContentIs('for ([] of []) { }');
diff --git a/tests/cases/fourslash/syntacticClassificationsForOfKeyword.ts b/tests/cases/fourslash/syntacticClassificationsForOfKeyword.ts
@@ -0,0 +1,16 @@
+/// <reference path="fourslash.ts"/>
+
+//// for (var of of of) { }
+
+var c = classification;
+verify.syntacticClassificationsAre(
+    c.keyword("for"),
+    c.punctuation("("),
+    c.keyword("var"),
+    c.text("of"),
+    c.keyword("of"),
+    c.text("of"),
+    c.punctuation(")"),
+    c.punctuation("{"),
+    c.punctuation("}")
+    );
diff --git a/tests/cases/fourslash/syntacticClassificationsForOfKeyword2.ts b/tests/cases/fourslash/syntacticClassificationsForOfKeyword2.ts
@@ -0,0 +1,16 @@
+/// <reference path="fourslash.ts"/>
+
+//// for (var of in of) { }
+
+var c = classification;
+verify.syntacticClassificationsAre(
+    c.keyword("for"),
+    c.punctuation("("),
+    c.keyword("var"),
+    c.text("of"),
+    c.keyword("in"),
+    c.text("of"),
+    c.punctuation(")"),
+    c.punctuation("{"),
+    c.punctuation("}")
+    );
diff --git a/tests/cases/fourslash/syntacticClassificationsForOfKeyword3.ts b/tests/cases/fourslash/syntacticClassificationsForOfKeyword3.ts
@@ -0,0 +1,18 @@
+/// <reference path="fourslash.ts"/>
+
+//// for (var of; of; of) { }
+
+var c = classification;
+verify.syntacticClassificationsAre(
+    c.keyword("for"),
+    c.punctuation("("),
+    c.keyword("var"),
+    c.text("of"),
+    c.punctuation(";"),
+    c.text("of"),
+    c.punctuation(";"),
+    c.text("of"),
+    c.punctuation(")"),
+    c.punctuation("{"),
+    c.punctuation("}")
+    );
diff --git a/tests/cases/unittests/services/colorization.ts b/tests/cases/unittests/services/colorization.ts
@@ -430,5 +430,20 @@ class D { }\r\n\
                 comment(">>>>>>> Branch - a"),
                 finalEndOfLineState(ts.EndOfLineState.Start));
         });
+
+        it("'of' keyword", function () {
+            testLexicalClassification("for (var of of of) { }",
+                ts.EndOfLineState.Start,
+                keyword("for"),
+                punctuation("("),
+                keyword("var"),
+                keyword("of"),
+                keyword("of"),
+                keyword("of"),
+                punctuation(")"),
+                punctuation("{"),
+                punctuation("}"),
+                finalEndOfLineState(ts.EndOfLineState.Start));
+        });
     });
 });

Original file line number	Diff line number	Diff line change
`@@ -464,6 +464,9 @@ module ts.formatting {`
`464`	`464`	`// "in" keyword in for (var x in []) { }`
`465`	`465`	`case SyntaxKind.ForInStatement:`
`466`	`466`	`return context.currentTokenSpan.kind === SyntaxKind.InKeyword \|\| context.nextTokenSpan.kind === SyntaxKind.InKeyword;`
	`467`	`+ // Technically, "of" is not a binary operator, but format it the same way as "in"`
	`468`	`+ case SyntaxKind.ForOfStatement:`
	`469`	`+ return context.currentTokenSpan.kind === SyntaxKind.OfKeyword \|\| context.nextTokenSpan.kind === SyntaxKind.OfKeyword;`
`467`	`470`	`}`
`468`	`471`	`return false;`
`469`	`472`	`}`