parse jsdoc param tag even without a param name

zhengbli · zhengbli · commit 582b0aa31e2e · 2015-08-21T13:07:41.000-07:00
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -5831,7 +5831,6 @@ namespace ts {
 
                     if (!name) {
                         parseErrorAtPosition(pos, 0, Diagnostics.Identifier_expected);
-                        return undefined;
                     }
 
                     let preName: Identifier, postName: Identifier;
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -2989,7 +2989,8 @@ namespace ts {
                     switch (tag.kind) {
                         case SyntaxKind.JSDocTypeTag:
                         case SyntaxKind.JSDocParameterTag:
-                            let tagWithExpression = <JSDocTypeTag | JSDocParameterTag>tag;
+                        case SyntaxKind.JSDocReturnTag:
+                            let tagWithExpression = <JSDocTypeTag | JSDocParameterTag | JSDocReturnTag>tag;
                             if (tagWithExpression.typeExpression) {
                                 insideJsDocTagExpression = tagWithExpression.typeExpression.pos < position && position < tagWithExpression.typeExpression.end;
                             }
diff --git a/tests/cases/fourslash/completionInJsDoc.ts b/tests/cases/fourslash/completionInJsDoc.ts
@@ -22,6 +22,12 @@
 ////
 ////// @pa/*7*/
 ////var v7;
+////
+/////** @param { n/*8*/ } */
+////var v8;
+////
+/////** @return { n/*9*/ } */
+////var v9;
 
 goTo.marker('1');
 verify.completionListContains("constructor");
@@ -48,3 +54,9 @@ verify.completionListIsEmpty();
 goTo.marker('7');
 verify.completionListIsEmpty();
 
+goTo.marker('8');
+verify.completionListContains('number');
+
+goTo.marker('9');
+verify.completionListContains('number');
+

Original file line number	Diff line number	Diff line change
`@@ -5831,7 +5831,6 @@ namespace ts {`
`5831`	`5831`
`5832`	`5832`	`if (!name) {`
`5833`	`5833`	`parseErrorAtPosition(pos, 0, Diagnostics.Identifier_expected);`
`5834`		`- return undefined;`
`5835`	`5834`	`}`
`5836`	`5835`
`5837`	`5836`	`let preName: Identifier, postName: Identifier;`