Avoid loading duplicate local+global plugins

RyanCavanaugh · RyanCavanaugh · commit 19ddc1e94a85 · 2017-04-13T16:17:34.000-07:00
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -885,6 +885,9 @@ namespace ts.server {
             }
             // Enable global plugins with synthetic configuration entries
             for (const globalPluginName of this.projectService.globalPlugins) {
+                // Skip already-locally-loaded plugins
+                if (options.plugins.some(p => p.name === globalPluginName)) continue;
+                
                 // Provide global: true so plugins can detect why they can't find their config
                 this.enablePlugin({ name: globalPluginName, global: true } as PluginImport, searchPaths);
             }

Original file line number	Diff line number	Diff line change
`@@ -885,6 +885,9 @@ namespace ts.server {`
`885`	`885`	`}`
`886`	`886`	`// Enable global plugins with synthetic configuration entries`
`887`	`887`	`for (const globalPluginName of this.projectService.globalPlugins) {`
	`888`	`+ // Skip already-locally-loaded plugins`
	`889`	`+ if (options.plugins.some(p => p.name === globalPluginName)) continue;`
	`890`	`+`
`888`	`891`	`// Provide global: true so plugins can detect why they can't find their config`
`889`	`892`	`this.enablePlugin({ name: globalPluginName, global: true } as PluginImport, searchPaths);`
`890`	`893`	`}`