Remove one-based helper function.

CyrusNajmabadi · CyrusNajmabadi · commit 1098e80f4bba · 2015-02-16T17:41:07.000-08:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -1733,6 +1733,13 @@ module ts {
                     }
                 }
 
+                function getOneBasedLineAndCharacterOfPosition(sourceFile: SourceFile, pos: number) {
+                    var result = getZeroBasedLineAndCharacterOfPosition(sourceFile, pos);
+                    result.line++;
+                    result.character++;
+                    return result;
+                }
+
                 function recordSourceMapSpan(pos: number) {
                     var sourceLinePos = getOneBasedLineAndCharacterOfPosition(currentSourceFile, pos);
                     var emittedLine = writer.getLine();
diff --git a/src/compiler/scanner.ts b/src/compiler/scanner.ts
@@ -319,10 +319,6 @@ module ts {
         return computeZeroBasedLineAndCharacterOfPosition(getLineStarts(sourceFile), position);
     }
 
-    export function getOneBasedLineAndCharacterOfPosition(sourceFile: SourceFile, position: number): LineAndCharacter {
-        return computeOneBasedLineAndCharacterOfPosition(getLineStarts(sourceFile), position);
-    }
-
     var hasOwnProperty = Object.prototype.hasOwnProperty;
 
     export function isWhiteSpace(ch: number): boolean {
diff --git a/src/compiler/tsc.ts b/src/compiler/tsc.ts
@@ -72,7 +72,7 @@ module ts {
     function countLines(program: Program): number {
         var count = 0;
         forEach(program.getSourceFiles(), file => {
-            count += getOneBasedLineAndCharacterOfPosition(file, file.end).line;
+            count += getLineStarts(file).length;
         });
         return count;
     }
@@ -86,9 +86,9 @@ module ts {
         var output = "";
         
         if (diagnostic.file) {
-            var loc = getOneBasedLineAndCharacterOfPosition(diagnostic.file, diagnostic.start);
+            var loc = getZeroBasedLineAndCharacterOfPosition(diagnostic.file, diagnostic.start);
 
-            output += diagnostic.file.fileName + "(" + loc.line + "," + loc.character + "): ";
+            output += diagnostic.file.fileName + "(" + (loc.line + 1) + "," + (loc.character + 1) + "): ";
         }
 
         var category = DiagnosticCategory[diagnostic.category].toLowerCase();
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -118,8 +118,8 @@ module ts {
     // This is a useful function for debugging purposes.
     export function nodePosToString(node: Node): string {
         var file = getSourceFileOfNode(node);
-        var loc = getOneBasedLineAndCharacterOfPosition(file, node.pos);
-        return file.fileName + "(" + loc.line + "," + loc.character + ")";
+        var loc = getZeroBasedLineAndCharacterOfPosition(file, node.pos);
+        return file.fileName + "(" + (loc.line + 1) + "," + (loc.character + 1) + ")";
     }
 
     export function getStartPosOfNode(node: Node): number {
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -756,7 +756,10 @@ module ts {
         }
 
         public getOneBasedLineAndCharacterOfPosition(position: number): LineAndCharacter {
-            return ts.getOneBasedLineAndCharacterOfPosition(this, position);
+            var result = ts.getZeroBasedLineAndCharacterOfPosition(this, position);
+            result.line++;
+            result.character++;
+            return result;
         }
 
         public getLineStarts(): number[] {

Original file line number	Diff line number	Diff line change
`@@ -1733,6 +1733,13 @@ module ts {`
`1733`	`1733`	`}`
`1734`	`1734`	`}`
`1735`	`1735`
	`1736`	`+ function getOneBasedLineAndCharacterOfPosition(sourceFile: SourceFile, pos: number) {`
	`1737`	`+ var result = getZeroBasedLineAndCharacterOfPosition(sourceFile, pos);`
	`1738`	`+ result.line++;`
	`1739`	`+ result.character++;`
	`1740`	`+ return result;`
	`1741`	`+ }`
	`1742`	`+`
`1736`	`1743`	`function recordSourceMapSpan(pos: number) {`
`1737`	`1744`	`var sourceLinePos = getOneBasedLineAndCharacterOfPosition(currentSourceFile, pos);`
`1738`	`1745`	`var emittedLine = writer.getLine();`
Original file line number	Diff line number	Diff line change
`@@ -319,10 +319,6 @@ module ts {`
`319`	`319`	`return computeZeroBasedLineAndCharacterOfPosition(getLineStarts(sourceFile), position);`
`320`	`320`	`}`
`321`	`321`
`322`		`- export function getOneBasedLineAndCharacterOfPosition(sourceFile: SourceFile, position: number): LineAndCharacter {`
`323`		`- return computeOneBasedLineAndCharacterOfPosition(getLineStarts(sourceFile), position);`
`324`		`- }`
`325`		`-`
`326`	`322`	`var hasOwnProperty = Object.prototype.hasOwnProperty;`
`327`	`323`
`328`	`324`	`export function isWhiteSpace(ch: number): boolean {`
Original file line number	Diff line number	Diff line change
`@@ -756,7 +756,10 @@ module ts {`
`756`	`756`	`}`
`757`	`757`
`758`	`758`	`public getOneBasedLineAndCharacterOfPosition(position: number): LineAndCharacter {`
`759`		`- return ts.getOneBasedLineAndCharacterOfPosition(this, position);`
	`759`	`+ var result = ts.getZeroBasedLineAndCharacterOfPosition(this, position);`
	`760`	`+ result.line++;`
	`761`	`+ result.character++;`
	`762`	`+ return result;`
`760`	`763`	`}`
`761`	`764`
`762`	`765`	`public getLineStarts(): number[] {`