Fix #19539 - Insert/edit form error with invisible columns - #20565

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.44%. Comparing base (9db6360) to head (6b2dd37).
⚠️ Report is 3 commits behind head on QA_5_2.

@@             Coverage Diff              @@
##             QA_5_2   #20565      +/-   ##
============================================
+ Coverage     50.42%   50.44%   +0.02%     
- Complexity    17261    17264       +3     
============================================
  Files           607      607              
  Lines         68333    68340       +7     
============================================
+ Hits          34455    34476      +21     
+ Misses        33878    33864      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

If all you want to do is skip this column look at the line 2516. Filtering like this in getTableColumns is a very nasty way of solving this problem.

Skipping at line 2516 alone is not enough: getHtmlForInsertEditFormColumn() reads getFieldsMeta($currentResult)[$columnNumber]->length (line 2134) by the table column position, and the result of SELECT * has no entry for the invisible column. With the GIPK my_row_id as the first column, every following column gets the metadata of its neighbour and the last one has none, which is the Undefined array key from #19539.

Two ways that I see:

1. Skip invisible columns at line 2516 and keep a separate index for the result metadata (only counts columns that are in the result).
2. Select the columns explicitly instead of SELECT * (lines 179 and 265), so invisible columns are in the result, the metadata lines up, and they can be edited in the form like any other column.

Which one would you prefer?

What do you mean is not enough? I don't understand your reply.

Sorry, I'll be more concrete. Take the table from #19539:

CREATE TABLE `user` (
  `my_row_id` bigint unsigned NOT NULL AUTO_INCREMENT INVISIBLE,
  `id` char(36) NOT NULL,
  `created_at` timestamp NOT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  PRIMARY KEY (`my_row_id`)
);

$tableColumns has 4 entries ($columnNumber 0 to 3), but SELECT * returns only 3 fields, so getFieldsMeta($currentResult) has indexes 0 to 2. For columns without a length in the type (timestamp here), getHtmlForInsertEditFormColumn() does

$column['len'] = $this->dbi->getFieldsMeta($currentResult)[$columnNumber]->length;

For updated_at that is index 3, which does not exist: this is the Undefined array key from the report. If I only add continue for invisible columns at line 2516, my_row_id is skipped, but updated_at still has $columnNumber 3 and still fails (and created_at gets the length of updated_at).

So skipping is fine for the invisible column itself, but the metadata lookup at that line also needs the position of the column in the result, not in the table. Shall I do it that way (skip at 2516 and pass the result position for the metadata), or do you have something else in mind?

Ok, I understand now. So the only two options are:

1. Filter invisible columns in getTableColumns()
2. Refactor the code to build the SQL listing all columns explicitely instead of SELECT * and then, if desirable, skip invisible columns when building the form, but not with in_array which cannot check for combined extra values.

In that case, filtering them out in getTableColumns() is the simplest solution for 5.2.

Applied the suggestion (str_contains). Thanks for looking into it.