Repository navigation
Conversation
A removed storage engine can leave a table without a row count or column metadata. Avoid formatting a null row count and render the designer table without inventing an empty column. Fixes phpmyadmin#20493 Signed-off-by: kenny-ish <114967656+kenny-ish@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20493
When a storage engine is removed, MariaDB can leave table metadata with a null row count and without column metadata. The database structure template passed the null value to
format_number(), while the designer template treated an empty column list as one empty column.This change:
TABLE_ROWSis nullTest plan
composer run phpunit -- --testsuite unit --filter 'TemplateTest::testRender(DesignerTableWithoutColumnMetadata|StructureTableWithoutRowCount)' --no-coverage --display-all-issuescomposer run phpunit -- --testsuite unit --display-all-issues --no-coverage./tests/ci-phplintcomposer phpcscomposer run twig-lintcomposer phpstan -- --memory-limit 2Gcomposer psalmChecklist