Fix Gis editor form in search view - #20413
Open
MoonE wants to merge 2 commits into
Open
Conversation
There is one event listener added in change.ts and one in select.ts, but there should only be one active at a time. Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
HTML form elements cannot be nested, the inner form element was silently stripped out of the dom which mean it could not be found when searching for its id. Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
MoonE
marked this pull request as draft
August 9, 2026 12:34
MoonE
marked this pull request as ready for review
August 9, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening the GIS editor form the search view produced an error because both
'show.bs.modal'listeners were active. (from change.ts and select.ts)Also copying the value from the editor to the search form did not work because the editor modal which has its own form element was inside the search form element. Nested form elements are stripped away by the browser.