Blur focused element when hiding the GIS editor modal - #20365
Open
CornElDos wants to merge 1 commit into
Open
Conversation
When the GIS editor modal (#gisEditorModal) is dismissed, a focused descendant such as the close button keeps focus while Bootstrap sets aria-hidden="true" on the modal. Browsers then block aria-hidden and warn that the focused element is hidden from assistive technology. Move focus out of the modal on hide.bs.modal, before it becomes aria-hidden, by blurring the focused descendant. Fixes phpmyadmin#19793 Signed-off-by: Cornelii Sandberg <corresandberg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the GIS editor modal (
#gisEditorModal) is dismissed, a focused descendant — typically the close button (.btn-close, which carriesdata-bs-dismiss="modal") — keeps focus while Bootstrap setsaria-hidden="true"on the modal. Browsers then block the attribute and log:This moves focus out of the modal on the
hide.bs.modalevent (which fires before the modal becomesaria-hidden) by blurring the focused descendant, so focus returns to the document body and the warning no longer occurs.The handler is added in the two places that wire up
#gisEditorModal(resources/js/table/select.tsandresources/js/table/change.ts), mirroring the existingshow.bs.modalhandlers there.Fixes #19793
How to test
Esc).The commit is signed off per the DCO.