Fix #19728 - Match available charsets case-insensitively#20329
Open
eyupcanakman wants to merge 1 commit into
Open
Fix #19728 - Match available charsets case-insensitively#20329eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
Encoding::listEncodings() applied strtolower to mb_list_encodings() and matched the result against AvailableCharsets with a case-sensitive array_intersect, so uppercase entries like SJIS were dropped and selecting SJIS for a CSV export had no effect. Signed-off-by: Eyüp Can Akman <eyupcanakman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Encoding::listEncodings()appliedstrtolowertomb_list_encodings()and matched the result againstAvailableCharsetswith a case-sensitivearray_intersect, so uppercase entries likeSJISwere dropped from the supported list. SelectingSJISfor a CSV export then had no effect and the file stayed UTF-8. The mbstring branch now matches the two ignoring case.Fixes #19728.