Skip to content

Apply order_by to multi-table query builder criteria#20327

Open
DPinheiro24 wants to merge 1 commit into
phpmyadmin:QA_5_2from
DPinheiro24:bug-query-build-sorting
Open

Apply order_by to multi-table query builder criteria#20327
DPinheiro24 wants to merge 1 commit into
phpmyadmin:QA_5_2from
DPinheiro24:bug-query-build-sorting

Conversation

@DPinheiro24

Copy link
Copy Markdown

Description

Please describe your pull request.
In the multi-table query builder there is a criteria checkbox that shows new fields to make the query more precise. The sort radio inputs in the fields seem to be empty of values. Basing myself with the logic of generateWhereBlock I added what was necessary for the "ORDER BY" to be inserted on the query.

Fixes #17841

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: DPinheiro24 <diogoapinheiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants